oblachno-oss/grm
3
0
Fork 0
Code Issues 31 Pull Requests Actions Packages Projects Releases 19 Wiki Activity

GRM-49: Define and enforce a structured review checklist for AI agents #47

Closed
emil wants to merge 0 commits from GRM-49-review-checklist into master
pull from: GRM-49-review-checklist
merge into: :master
Conversation 4 Commits - Files Changed -
emil commented 2026-06-22 00:12:59 +00:00
Owner
Copy Link
Copy Source

What

PR reviews were ad-hoc — the agent had a list of focus areas in AGENTS.md but nothing enforced that each category was actually reviewed.

Solution

Created REVIEW_CHECKLIST.md with 10 mandatory categories and enforcement at the tool level:

1. REVIEW_CHECKLIST.md

10 categories, each with specific checkbox items marked [auto] or [manual]:

  1. Architecture Compliance
  2. Code Quality and Best Practices
  3. Security
  4. Internationalization (i18n)
  5. Testability and Test Coverage
  6. Performance
  7. User Experience
  8. Documentation
  9. Workflow Compliance
  10. Extensibility and Maintainability

2. review_pr.py — --checklist-confirmed flag

APPROVE events now require --checklist-confirmed. Without it, the script rejects the approval. Also enforces substantive body (> 20 chars) or inline comments.

3. pr_review.py — Checklist reference in review body

The automated review body now includes a link to REVIEW_CHECKLIST.md and instructions for manual review with --checklist-confirmed.

4. AGENTS.md — Updated workflow documentation

Section 6 (Review) now references the checklist. Section 8 (Approve) shows the --checklist-confirmed flag in the example command.

Closes GRM-49

## What PR reviews were ad-hoc — the agent had a list of focus areas in AGENTS.md but nothing enforced that each category was actually reviewed. ## Solution Created REVIEW_CHECKLIST.md with 10 mandatory categories and enforcement at the tool level: ### 1. REVIEW_CHECKLIST.md 10 categories, each with specific checkbox items marked [auto] or [manual]: 1. Architecture Compliance 2. Code Quality and Best Practices 3. Security 4. Internationalization (i18n) 5. Testability and Test Coverage 6. Performance 7. User Experience 8. Documentation 9. Workflow Compliance 10. Extensibility and Maintainability ### 2. review_pr.py — --checklist-confirmed flag APPROVE events now require --checklist-confirmed. Without it, the script rejects the approval. Also enforces substantive body (> 20 chars) or inline comments. ### 3. pr_review.py — Checklist reference in review body The automated review body now includes a link to REVIEW_CHECKLIST.md and instructions for manual review with --checklist-confirmed. ### 4. AGENTS.md — Updated workflow documentation Section 6 (Review) now references the checklist. Section 8 (Approve) shows the --checklist-confirmed flag in the example command. Closes GRM-49
emil reviewed 2026-06-22 00:14:05 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • Documentation: OK
  • Tests: OK

No issues found by automated checks.

Manual review required: Before approving, review every category in
REVIEW_CHECKLIST.md and confirm with:

python3 scripts/ci/review_pr.py <PR> <owner/repo> \
  --event APPROVE --checklist-confirmed \
  --body "<substantive review summary>"
## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - Documentation: OK - Tests: OK No issues found by automated checks. --- **Manual review required:** Before approving, review every category in [REVIEW_CHECKLIST.md](REVIEW_CHECKLIST.md) and confirm with: ```bash python3 scripts/ci/review_pr.py <PR> <owner/repo> \ --event APPROVE --checklist-confirmed \ --body "<substantive review summary>" ```
emil added the ready-to-merge label 2026-06-22 00:19:52 +00:00
emil force-pushed GRM-49-review-checklist from 25b3e57d51 to 3be3406270 2026-06-22 00:29:18 +00:00 Compare
emil reviewed 2026-06-22 00:30:49 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • Documentation: OK
  • Tests: OK

No issues found by automated checks.

Manual review required: Before approving, review every category in
REVIEW_CHECKLIST.md and confirm with:

python3 scripts/ci/review_pr.py <PR> <owner/repo> \
  --event APPROVE --checklist-confirmed \
  --body "<substantive review summary>"
## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - Documentation: OK - Tests: OK No issues found by automated checks. --- **Manual review required:** Before approving, review every category in [REVIEW_CHECKLIST.md](REVIEW_CHECKLIST.md) and confirm with: ```bash python3 scripts/ci/review_pr.py <PR> <owner/repo> \ --event APPROVE --checklist-confirmed \ --body "<substantive review summary>" ```
emil force-pushed GRM-49-review-checklist from 3be3406270 to 25b3e57d51 2026-06-22 00:36:39 +00:00 Compare
emil force-pushed GRM-49-review-checklist from 25b3e57d51 to 70b5fba736 2026-06-22 00:37:16 +00:00 Compare
emil reviewed 2026-06-22 00:37:54 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • Documentation: OK
  • Tests: OK

No issues found by automated checks.

Manual review required: Before approving, review every category in
REVIEW_CHECKLIST.md and confirm with:

python3 scripts/ci/review_pr.py <PR> <owner/repo> \
  --event APPROVE --checklist-confirmed \
  --body "<substantive review summary>"
## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - Documentation: OK - Tests: OK No issues found by automated checks. --- **Manual review required:** Before approving, review every category in [REVIEW_CHECKLIST.md](REVIEW_CHECKLIST.md) and confirm with: ```bash python3 scripts/ci/review_pr.py <PR> <owner/repo> \ --event APPROVE --checklist-confirmed \ --body "<substantive review summary>" ```
emil reviewed 2026-06-22 00:39:11 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • Documentation: OK
  • Tests: OK

No issues found by automated checks.

Manual review required: Before approving, review every category in
REVIEW_CHECKLIST.md and confirm with:

python3 scripts/ci/review_pr.py <PR> <owner/repo> \
  --event APPROVE --checklist-confirmed \
  --body "<substantive review summary>"
## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - Documentation: OK - Tests: OK No issues found by automated checks. --- **Manual review required:** Before approving, review every category in [REVIEW_CHECKLIST.md](REVIEW_CHECKLIST.md) and confirm with: ```bash python3 scripts/ci/review_pr.py <PR> <owner/repo> \ --event APPROVE --checklist-confirmed \ --body "<substantive review summary>" ```
emil closed this pull request 2026-06-22 00:44:47 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
emil
Labels
Clear labels
bug
Something is not working
 ci-improvement
CI workflow improvements
 doc-improvement
Documentation improvements
 feedback
Issues from subagent or agent feedback
 ready-to-merge
Auto-merge PR when all CI checks pass
 refactoring
Large refactoring PR — bypasses size check
 tooling
Tool-related feedback or improvements
 workflow-improvement
Workflow alignment or pattern improvements
No labels ready-to-merge
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
emil (emil User) emo kireto
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: oblachno-oss/grm#47