GRM-170: Fix stall-detection robustness bugs in runner healthcheck #277

Merged
kireto merged 2 commits from GRM-170-stall-diag-robustness into master 2026-09-18 11:19:16 +00:00
Member
No description provided.
kireto added 1 commit 2026-09-18 11:01:51 +00:00
fix: harden stall-detection enumeration and timestamp parsing
CI / validate (pull_request) Successful in 1m9s
CI / molecule-tests (1) (pull_request) Successful in 5m49s
CI / molecule-tests (3) (pull_request) Successful in 6m47s
CI / molecule-tests (2) (pull_request) Successful in 7m10s
CI / molecule-tests (4) (pull_request) Successful in 7m12s
CI / auto-merge (pull_request) Failing after 7m50s
a61075ebde
Post-merge review of GRM-168 found three defects: the docker ps
feeding the probe loop lacked a failure guard, so a slow daemon would
abort the healthcheck under pipefail exactly when diagnostics matter;
CreatedAt contains spaces so whitespace-splitting read only captured
the date and broke the 15-minute age gate (GNU date also rejects the
+0000 UTC suffix); and head -200 could truncate the inspect State
block the spec requires. Pipe-separated fields, guarded enumeration,
stripped UTC suffix, and full inspect output fix all three.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
emil added 1 commit 2026-09-18 11:10:15 +00:00
fix: redact secret env values in stall diagnostics inspect output
CI / validate (pull_request) Successful in 1m9s
CI / molecule-tests (1) (pull_request) Successful in 5m23s
CI / molecule-tests (3) (pull_request) Successful in 7m5s
CI / molecule-tests (2) (pull_request) Successful in 7m27s
CI / molecule-tests (4) (pull_request) Successful in 7m31s
CI / auto-merge (pull_request) Successful in 7m50s
8cd0d4dd57
docker inspect captures the container Env block, which for CI job
containers carries CI_GITEA_API_TOKEN and similar secrets — the diag
bundle must not become a secret artifact (OBL-INFRA-548 S02).

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
emil approved these changes 2026-09-18 11:10:48 +00:00
Dismissed
emil left a comment
Owner

Auto-approved: all CI checks passed (validate, molecule-tests).

Auto-approved: all CI checks passed (validate, molecule-tests).
emil approved these changes 2026-09-18 11:12:38 +00:00
emil left a comment
Owner

Auto-approved: all CI checks passed (validate, molecule-tests).

Auto-approved: all CI checks passed (validate, molecule-tests).
kireto merged commit 2e14bc3141 into master 2026-09-18 11:19:16 +00:00
kireto deleted branch GRM-170-stall-diag-robustness 2026-09-18 11:19:17 +00:00
Sign in to join this conversation.