GRM-159: remove molecule_ci_guard and fix shell for molecule tests #248

Merged
emo merged 6 commits from GRM-159-remove-molecule-ci-guard into master 2026-08-09 11:12:39 +00:00
6 Commits
Author SHA1 Message Date
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 4230385c75 fix(healthcheck): split gentle prune — until filter incompatible with --volumes
CI / validate (pull_request) Successful in 1m32s
CI / molecule-tests (1) (pull_request) Successful in 5m20s
CI / molecule-tests (3) (pull_request) Successful in 5m49s
CI / molecule-tests (2) (pull_request) Successful in 7m23s
CI / molecule-tests (4) (pull_request) Successful in 7m27s
CI / auto-merge (pull_request) Successful in 58s
Docker's "until" filter is not supported with "--volumes", causing the
gentle prune to fail silently every 2 minutes:
  ERROR: The "until" filter is not supported with "--volumes"

This left disk at 74% indefinitely — the gentle prune was a no-op.
Now prune images and containers with the until filter separately,
then prune volumes without a filter.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-08-09 13:02:23 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 41357a3a34 fix(healthcheck): lower critical prune threshold to 75%
CI / validate (pull_request) Successful in 3m46s
CI / molecule-tests (3) (pull_request) Failing after 5m59s
CI / molecule-tests (4) (pull_request) Failing after 5m32s
CI / molecule-tests (1) (pull_request) Successful in 7m21s
CI / molecule-tests (2) (pull_request) Successful in 9m59s
CI / auto-merge (pull_request) Skipped
At 76%, molecule containers fail with "container is not running" because
overlay2 runs out of space under parallel DinD load. The gentle prune
(until=1h) at 75% was insufficient — runners stayed at 76% because
nothing was older than 1h on busy runners.

Lower the critical threshold to 75% so the full prune (no until filter)
triggers immediately when disk reaches the level where tests fail. Also
lower the gentle prune threshold to 70% to start cleanup earlier.

This matches the infra CI disk gate which skips tests at 75%+.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-08-09 12:15:41 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 7589329170 feat(healthcheck): add two-tier disk prune with critical threshold
CI / validate (pull_request) Successful in 1m37s
CI / molecule-tests (2) (pull_request) Successful in 5m49s
CI / molecule-tests (4) (pull_request) Failing after 6m16s
CI / molecule-tests (3) (pull_request) Failing after 6m18s
CI / molecule-tests (1) (pull_request) Failing after 7m6s
CI / auto-merge (pull_request) Skipped
The healthcheck previously used a single 75% threshold with an
until=1h filter. On busy runners with constant CI jobs, nothing
is older than 1h, so the prune barely frees anything — disk stays
at ~76% and the CI disk gate (80%) skips all molecule tests.

Two-tier approach:
- 75-79%: gentle prune (until=1h) — same as before
- 80%+:   full prune (no until filter) — removes ALL stopped
          containers and unused images regardless of age, plus
          builder cache and networks

This ensures that when disk pressure is critical, the healthcheck
actually reclaims space instead of skipping everything that's
recently created.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-08-09 12:11:13 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 56b9d58ab7 fix(ci): use pushd/popd instead of molecule --cwd
CI / validate (pull_request) Successful in 1m30s
CI / molecule-tests (1) (pull_request) Skipped
CI / molecule-tests (2) (pull_request) Skipped
CI / molecule-tests (3) (pull_request) Skipped
CI / molecule-tests (4) (pull_request) Skipped
CI / auto-merge (pull_request) Skipped
Molecule doesn't support --cwd flag. Use pushd/popd to change
directory before running molecule test/destroy.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-08-09 02:42:21 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 40f123c99c fix(ci): use shell: bash for molecule test step
CI / auto-merge (pull_request) Skipped
CI / validate (pull_request) Failing after 1m45s
CI / molecule-tests (1) (pull_request) Skipped
CI / molecule-tests (2) (pull_request) Skipped
CI / molecule-tests (3) (pull_request) Skipped
CI / molecule-tests (4) (pull_request) Skipped
The inline molecule runner uses bashisms (here-strings `<<<`,
parameter expansion) that dash/sh doesn't support. Gitea Actions
defaults to sh, causing "Syntax error: redirection unexpected".

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-08-09 02:30:26 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 6be805e5b1 refactor: remove molecule_ci_guard — adds complexity, no value
The cross-runner cancellation guard was killing healthy molecule slots
when unhealthy slots failed, defeating fail-fast: false. Replace with
direct molecule test execution.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-08-09 02:19:08 +02:00