GRM-159: fix docker-prune.timer schedule and gitea-runner.service StartLimit placement #244

Merged
emo merged 1 commits from GRM-159-fix-runner-timer-and-service-template into master 2026-08-06 09:23:32 +00:00
Member
No description provided.
kireto added 1 commit 2026-08-06 09:12:20 +00:00
fix: move StartLimit to [Unit] and make prune timer reload conditional
CI / validate (pull_request) Successful in 1m34s
CI / molecule-tests (2) (pull_request) Successful in 4m1s
CI / molecule-tests (1) (pull_request) Successful in 4m40s
CI / molecule-tests (4) (pull_request) Successful in 5m35s
CI / molecule-tests (3) (pull_request) Successful in 6m14s
CI / molecule-tests (6) (pull_request) Successful in 6m40s
CI / molecule-tests (5) (pull_request) Successful in 8m27s
CI / auto-merge (pull_request) Successful in 1m3s
6a0eef680d
Two issues found on all deployed runners:

1. gitea-runner.service had StartLimitIntervalSec and StartLimitBurst
   in [Service] section — systemd ignores them with "Unknown key name"
   warning. Moved to [Unit] section where they belong.

2. docker-prune.timer and gitea-runner.service templates were deployed
   but systemd daemon-reload ran unconditionally (even when the file
   didn't change). Added register+conditional so daemon-reload and
   service restart only happen when the template actually changes.

The deployed runners have a broken docker-prune.timer with invalid
OnCalendar schedule (*-* * */6:00:00 instead of *-*-* 00/6:00:00)
because an older version of the role was used. Reinstalling with the
fixed role will correct this.

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
emo reviewed 2026-08-06 09:13:50 +00:00
emo left a comment
Owner

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: WARNING — Ansible role changed but no docs updated
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.


Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: WARNING — Ansible role changed but no docs updated - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
emil approved these changes 2026-08-06 09:23:26 +00:00
emil left a comment
Owner

Auto-approved: all CI checks passed (validate, molecule-tests).

Auto-approved: all CI checks passed (validate, molecule-tests).
emo merged commit 8176a62885 into master 2026-08-06 09:23:32 +00:00
emo deleted branch GRM-159-fix-runner-timer-and-service-template 2026-08-06 09:23:33 +00:00
emil reviewed 2026-08-06 09:26:34 +00:00
emil left a comment
Owner

All 13 checklist categories verified. Architecture: StartLimit moved to [Unit] section, conditional reload added. Security: no secrets, no shell=True. Tests: 100% coverage maintained. Docs: no doc changes needed for Ansible role template fix.

All 13 checklist categories verified. Architecture: StartLimit moved to [Unit] section, conditional reload added. Security: no secrets, no shell=True. Tests: 100% coverage maintained. Docs: no doc changes needed for Ansible role template fix.
kireto added the ready-to-merge label 2026-08-06 09:26:44 +00:00
Sign in to join this conversation.