oblachno-oss/grm
2
0
Fork 0
Code Issues 12 Pull Requests 1 Actions Packages Projects Releases 7 Wiki Activity

GRM-161: Fix register.yml premature service start before unit file exists #238

Merged
emil merged 0 commits from GRM-161-fix-register-service-start into master 2026-08-12 22:35:26 +00:00
Conversation 12 Commits - Files Changed -
emil commented 2026-08-12 19:59:13 +00:00
Owner
Copy Link
Copy Source

Removed premature service start from register.yml. The systemd unit file is created by service.yml (included after register.yml), so starting the service in register.yml fails with Unit gitea-runner.service not found. service.yml already handles starting the service.

Closes GRM-161

Removed premature service start from register.yml. The systemd unit file is created by service.yml (included after register.yml), so starting the service in register.yml fails with Unit gitea-runner.service not found. service.yml already handles starting the service. Closes GRM-161
emil reviewed 2026-08-12 20:00:30 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: WARNING — Ansible role changed but no docs updated
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.

Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: WARNING — Ansible role changed but no docs updated - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
kireto approved these changes 2026-08-12 20:01:46 +00:00
Dismissed
kireto left a comment
Member
Copy Link
Copy Source

Auto-approved: all CI checks passed (validate, molecule-tests).

Auto-approved: all CI checks passed (validate, molecule-tests).
emil dismissed kireto's review 2026-08-12 20:43:59 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

emil reviewed 2026-08-12 20:53:10 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: WARNING — Ansible role changed but no docs updated
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.

Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: WARNING — Ansible role changed but no docs updated - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
kireto approved these changes 2026-08-12 20:55:25 +00:00
Dismissed
kireto left a comment
Member
Copy Link
Copy Source

Auto-approved: all CI checks passed (validate, molecule-tests).

Auto-approved: all CI checks passed (validate, molecule-tests).
emil dismissed kireto's review 2026-08-12 21:30:03 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

emil added the ready-to-merge label 2026-08-12 21:31:15 +00:00
emil reviewed 2026-08-12 21:36:06 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: OK
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.

Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: OK - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
kireto approved these changes 2026-08-12 21:37:40 +00:00
Dismissed
kireto left a comment
Member
Copy Link
Copy Source

Auto-approved: all CI checks passed (validate, molecule-tests).

Auto-approved: all CI checks passed (validate, molecule-tests).
emil dismissed kireto's review 2026-08-12 21:43:59 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

emil reviewed 2026-08-12 21:50:54 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: OK
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.

Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: OK - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
kireto approved these changes 2026-08-12 21:53:13 +00:00
Dismissed
kireto left a comment
Member
Copy Link
Copy Source

Auto-approved: all CI checks passed (validate, molecule-tests).

Auto-approved: all CI checks passed (validate, molecule-tests).
emil reviewed 2026-08-12 22:03:05 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: OK
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.

Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: OK - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
kireto approved these changes 2026-08-12 22:04:58 +00:00
Dismissed
kireto left a comment
Member
Copy Link
Copy Source

Auto-approved: all CI checks passed (validate, molecule-tests).

Auto-approved: all CI checks passed (validate, molecule-tests).
emil reviewed 2026-08-12 22:23:51 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: OK
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.

Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: OK - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
kireto approved these changes 2026-08-12 22:25:12 +00:00
kireto left a comment
Member
Copy Link
Copy Source

Auto-approved: all CI checks passed (validate, molecule-tests).

Auto-approved: all CI checks passed (validate, molecule-tests).
emil merged commit 6cea042330 into master 2026-08-12 22:35:26 +00:00
emil deleted branch GRM-161-fix-register-service-start 2026-08-12 22:35:30 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
emil
kireto
Labels
Clear labels
bug
Something is not working
 ci-improvement
CI workflow improvements
 doc-improvement
Documentation improvements
 feedback
Issues from subagent or agent feedback
 ready-to-merge
Auto-merge PR when all CI checks pass
 tooling
Tool-related feedback or improvements
 workflow-improvement
Workflow alignment or pattern improvements
No labels ready-to-merge
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
emil (emil User) kireto
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: oblachno-oss/grm#238