oblachno-oss/grm
3
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases 15 Wiki Activity

GRM-83: Fix publish step: add build/twine to ci deps, fix notify_failure venv activation #120

Merged
emil merged 0 commits from GRM-83-fix-publish-build-deps into master 2026-06-24 22:28:09 +00:00
Conversation 2 Commits - Files Changed -
emil commented 2026-06-24 22:23:42 +00:00
Owner
Copy Link
Copy Source

Summary

  • Add build and twine to the ci optional dependency in pyproject.toml so they're installed by make setup-release
  • Fix notify_failure step in release job to activate venv before running (was failing with ModuleNotFoundError: No module named 'dotenv')

Same fix as DEVX-44. The publish step in post-merge would fail without build/twine installed.

Closes GRM-83

## Summary - Add `build` and `twine` to the `ci` optional dependency in pyproject.toml so they're installed by `make setup-release` - Fix notify_failure step in release job to activate venv before running (was failing with `ModuleNotFoundError: No module named 'dotenv'`) Same fix as DEVX-44. The publish step in post-merge would fail without build/twine installed. Closes GRM-83
emil reviewed 2026-06-24 22:24:01 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: OK
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.

Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: OK - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
emil force-pushed GRM-83-fix-publish-build-deps from 1922a117e6 to 127a82353a 2026-06-24 22:25:37 +00:00 Compare
emil reviewed 2026-06-24 22:26:02 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: OK
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.

Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: OK - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
emil merged commit 23d67bf215 into master 2026-06-24 22:28:09 +00:00
emil deleted branch GRM-83-fix-publish-build-deps 2026-06-24 22:28:09 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
emil
Labels
Clear labels
bug
Something is not working
 ci-improvement
CI workflow improvements
 doc-improvement
Documentation improvements
 feedback
Issues from subagent or agent feedback
 ready-to-merge
Auto-merge PR when all CI checks pass
 tooling
Tool-related feedback or improvements
 workflow-improvement
Workflow alignment or pattern improvements
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
emil (emil User) emo kireto
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: oblachno-oss/grm#120