oblachno-oss/grm
2
0
Fork 0
Code Issues 12 Pull Requests 1 Actions Packages Projects Releases 7 Wiki Activity

GRM-78: Fix publish workflow: add workflow_dispatch and update devx #114

Closed
emil wants to merge 0 commits from GRM-76-fix-publish-workflow into master
pull from: GRM-76-fix-publish-workflow
merge into: :master
Conversation 3 Commits - Files Changed -
emil commented 2026-06-24 19:39:16 +00:00
Owner
Copy Link
Copy Source

Changes

  • Add workflow_dispatch trigger with tag string input to .gitea/workflows/publish.yml, enabling manual publishing of any tag without needing a push event.
  • Update the publish step to use ${{ github.event.inputs.tag || github.ref_name }} so the tag comes from the manual input when dispatched, falling back to github.ref_name for tag-push triggers.
  • Bump DEVX_VERSION in Makefile from v0.9.11 to v0.9.12.
  • Update all 21 devx==0.9.11 references to devx==0.9.12 across .gitea/workflows/ci.yml, .gitea/workflows/post-merge.yml, and .gitea/workflows/publish.yml.

Closes GRM-76

## Changes - Add `workflow_dispatch` trigger with `tag` string input to `.gitea/workflows/publish.yml`, enabling manual publishing of any tag without needing a push event. - Update the publish step to use `${{ github.event.inputs.tag || github.ref_name }}` so the tag comes from the manual input when dispatched, falling back to `github.ref_name` for tag-push triggers. - Bump `DEVX_VERSION` in `Makefile` from `v0.9.11` to `v0.9.12`. - Update all 21 `devx==0.9.11` references to `devx==0.9.12` across `.gitea/workflows/ci.yml`, `.gitea/workflows/post-merge.yml`, and `.gitea/workflows/publish.yml`. Closes GRM-76
emil reviewed 2026-06-24 19:39:36 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: OK
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.

Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: OK - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
emil reviewed 2026-06-24 19:41:29 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

All 13 REVIEW_CHECKLIST.md categories verified.

  1. Architecture: No subprocess in CLI, no hardcoded URLs. Changes are workflow/infra-only — no source code touched. Compliant.
  2. Code Quality: No print(), no bare except, no TODO/FIXME, no functions > 50 lines. YAML and Makefile changes are clean and well-formed.
  3. Security: No hardcoded secrets, no shell=True, no eval/exec. Token references use existing secrets pattern. No new secret exposure.
  4. i18n: No user-facing strings changed — workflow YAML and Makefile only. N/A.
  5. Testing: No source changes requiring new tests. Workflow-only changes are exempt from test coverage requirements per classify_changes policy.
  6. Performance: No performance impact — workflow_dispatch trigger adds optional manual execution path without affecting existing tag-push flow.
  7. UX: No CLI or user interface changes. N/A.
  8. Documentation: Makefile comment already documents DEVX_VERSION update requirement. No additional docs needed for version bump.
  9. Workflow Compliance: Conventional commit format (fix:) used. PR title follows GRM-N format. Branch name matches task. Vikunja task created.
  10. Maintainability: devx version bump is mechanical (21 references updated consistently). workflow_dispatch pattern matches devx convention. Easy to maintain.
  11. Resource Management: No open() or Popen() changes. N/A.
  12. Backwards Compatibility: workflow_dispatch is additive — existing tag-push trigger unchanged. Fallback expression (github.event.inputs.tag || github.ref_name) preserves original behavior for push events.
  13. Logging: No logging changes. N/A.
All 13 REVIEW_CHECKLIST.md categories verified. 1. Architecture: No subprocess in CLI, no hardcoded URLs. Changes are workflow/infra-only — no source code touched. Compliant. 2. Code Quality: No print(), no bare except, no TODO/FIXME, no functions > 50 lines. YAML and Makefile changes are clean and well-formed. 3. Security: No hardcoded secrets, no shell=True, no eval/exec. Token references use existing secrets pattern. No new secret exposure. 4. i18n: No user-facing strings changed — workflow YAML and Makefile only. N/A. 5. Testing: No source changes requiring new tests. Workflow-only changes are exempt from test coverage requirements per classify_changes policy. 6. Performance: No performance impact — workflow_dispatch trigger adds optional manual execution path without affecting existing tag-push flow. 7. UX: No CLI or user interface changes. N/A. 8. Documentation: Makefile comment already documents DEVX_VERSION update requirement. No additional docs needed for version bump. 9. Workflow Compliance: Conventional commit format (fix:) used. PR title follows GRM-N format. Branch name matches task. Vikunja task created. 10. Maintainability: devx version bump is mechanical (21 references updated consistently). workflow_dispatch pattern matches devx convention. Easy to maintain. 11. Resource Management: No open() or Popen() changes. N/A. 12. Backwards Compatibility: workflow_dispatch is additive — existing tag-push trigger unchanged. Fallback expression (github.event.inputs.tag || github.ref_name) preserves original behavior for push events. 13. Logging: No logging changes. N/A.
emil added the ready-to-merge label 2026-06-24 19:41:55 +00:00
emil changed title from GRM-76: Fix publish workflow: add workflow_dispatch and update devx to GRM-78: Fix publish workflow: add workflow_dispatch and update devx 2026-06-24 19:42:41 +00:00
emil reviewed 2026-06-24 19:43:05 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: OK
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.

Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: OK - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
emil closed this pull request 2026-06-24 19:45:38 +00:00
emil deleted branch GRM-76-fix-publish-workflow 2026-06-24 19:45:38 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
emil
Labels
Clear labels
bug
Something is not working
 ci-improvement
CI workflow improvements
 doc-improvement
Documentation improvements
 feedback
Issues from subagent or agent feedback
 ready-to-merge
Auto-merge PR when all CI checks pass
 tooling
Tool-related feedback or improvements
 workflow-improvement
Workflow alignment or pattern improvements
No labels ready-to-merge
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
emil (emil User) kireto
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: oblachno-oss/grm#114