DEVX-34: Retrospective fixes for CI/CD friction #57

Merged
emil merged 0 commits from DEVX-34-retrospective-fixes into master 2026-06-24 16:41:23 +00:00
Owner

Summary

Retrospective fixes for issues that caused multiple CI cycles:

  • configure_repo: Parse owner/repo from DEVX_REPO_NAME when it contains a slash — prevents 404 when workflows set the full path
  • auto_merge: Warn when .taskid file disagrees with branch task ID — prevents silent mismatches when branching from an existing branch
  • config: Remove default oblachno-oss for REPO_OWNER — projects must set DEVX_REPO_OWNER explicitly (prevents silent 404s)
  • AGENTS.md: Document task ID resolution, always() requirement for auto-merge, and all DEVX_ env vars
  • Tests: Add coverage for slash parsing and stale .taskid warning

Closes DEVX-34

## Summary Retrospective fixes for issues that caused multiple CI cycles: - **configure_repo**: Parse `owner/repo` from `DEVX_REPO_NAME` when it contains a slash — prevents 404 when workflows set the full path - **auto_merge**: Warn when `.taskid` file disagrees with branch task ID — prevents silent mismatches when branching from an existing branch - **config**: Remove default `oblachno-oss` for `REPO_OWNER` — projects must set `DEVX_REPO_OWNER` explicitly (prevents silent 404s) - **AGENTS.md**: Document task ID resolution, `always()` requirement for auto-merge, and all `DEVX_` env vars - **Tests**: Add coverage for slash parsing and stale `.taskid` warning Closes DEVX-34
emil reviewed 2026-06-24 16:28:27 +00:00
emil left a comment
Author
Owner

Retrospective fixes addressing CI/CD friction. All 13 categories verified. Architecture: slash parsing is backward-compatible, warning-only for .taskid mismatch. Security: no hardcoded secrets, no shell=True. Tests: 1019 unit tests pass, new tests for slash parsing and stale .taskid warning. Docs: AGENTS.md updated with task ID resolution, always() requirement, and all DEVX_ env vars.

Retrospective fixes addressing CI/CD friction. All 13 categories verified. Architecture: slash parsing is backward-compatible, warning-only for .taskid mismatch. Security: no hardcoded secrets, no shell=True. Tests: 1019 unit tests pass, new tests for slash parsing and stale .taskid warning. Docs: AGENTS.md updated with task ID resolution, always() requirement, and all DEVX_ env vars.
emil added the ready-to-merge label 2026-06-24 16:28:44 +00:00
emil reviewed 2026-06-24 16:29:08 +00:00
emil left a comment
Author
Owner

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: OK
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.


Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: OK - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
emil reviewed 2026-06-24 16:40:42 +00:00
emil left a comment
Author
Owner

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: OK
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.


Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: OK - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
emil merged commit 3f2d19d7ac into master 2026-06-24 16:41:23 +00:00
emil deleted branch DEVX-34-retrospective-fixes 2026-06-24 16:41:23 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: oblachno-oss/devx#57