Extracts the inline bash script for starting Docker daemon in CI molecule tests into a proper Python module devx.molecule.start_docker with full test coverage (9 tests, 100% coverage).
The module:
Checks if Docker is already running (is_docker_ready())
Starts dockerd in background with start_new_session=True (no shell=True)
Waits with configurable timeout (default 30s)
CLI interface via python3 -m devx.molecule.start_docker [--timeout N]
Closes DEVX-20
## Summary
Extracts the inline bash script for starting Docker daemon in CI molecule tests into a proper Python module devx.molecule.start_docker with full test coverage (9 tests, 100% coverage).
The module:
- Checks if Docker is already running (is_docker_ready())
- Starts dockerd in background with start_new_session=True (no shell=True)
- Waits with configurable timeout (default 30s)
- CLI interface via python3 -m devx.molecule.start_docker [--timeout N]
Closes DEVX-20
Documentation: WARNING — source files changed but no docs updated
Tests: OK
Commit conventions: OK
No issues found by automated checks.
Auto-merge: If all CI checks pass, this PR will be merged automatically.
## Automated PR Review
- Architecture compliance: OK
- Best practices: OK
- Security: OK
- i18n: OK
- Resource management: OK
- Documentation: WARNING — source files changed but no docs updated
- Tests: OK
- Commit conventions: OK
No issues found by automated checks.
---
**Auto-merge:** If all CI checks pass, this PR will be merged automatically.
Documentation: WARNING — source files changed but no docs updated
Tests: OK
Commit conventions: OK
No issues found by automated checks.
Auto-merge: If all CI checks pass, this PR will be merged automatically.
## Automated PR Review
- Architecture compliance: OK
- Best practices: OK
- Security: OK
- i18n: OK
- Resource management: OK
- Documentation: WARNING — source files changed but no docs updated
- Tests: OK
- Commit conventions: OK
No issues found by automated checks.
---
**Auto-merge:** If all CI checks pass, this PR will be merged automatically.
Documentation: WARNING — source files changed but no docs updated
Tests: OK
Commit conventions: OK
No issues found by automated checks.
Auto-merge: If all CI checks pass, this PR will be merged automatically.
## Automated PR Review
- Architecture compliance: OK
- Best practices: OK
- Security: OK
- i18n: OK
- Resource management: OK
- Documentation: WARNING — source files changed but no docs updated
- Tests: OK
- Commit conventions: OK
No issues found by automated checks.
---
**Auto-merge:** If all CI checks pass, this PR will be merged automatically.
emil
merged commit b4b7428f9c into master2026-06-23 23:28:21 +00:00
emil
deleted branch DEVX-20-extract-docker-daemon-start2026-06-23 23:28:22 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
emil
Summary
Extracts the inline bash script for starting Docker daemon in CI molecule tests into a proper Python module devx.molecule.start_docker with full test coverage (9 tests, 100% coverage).
The module:
Closes DEVX-20
Automated PR Review
No issues found by automated checks.
Auto-merge: If all CI checks pass, this PR will be merged automatically.
All 13 REVIEW_CHECKLIST.md categories verified. Architecture: clean separation with is_docker_ready/start_docker_daemon functions. Security: nosec B603/B607 for subprocess calls, no shell=True. Tests: 9 tests covering all paths, 100% coverage. Docs: module docstring with usage examples.
Automated PR Review
No issues found by automated checks.
Auto-merge: If all CI checks pass, this PR will be merged automatically.
Automated PR Review
No issues found by automated checks.
Auto-merge: If all CI checks pass, this PR will be merged automatically.