DEVX-152: remove molecule_ci_guard — adds complexity, no value #265

Merged
emo merged 3 commits from DEVX-152-remove-molecule-ci-guard into master 2026-08-09 00:59:58 +00:00
Owner

Summary

The cross-runner cancellation guard (molecule_ci_guard) was killing healthy molecule slots when unhealthy slots failed on high-disk runners, defeating fail-fast: false. With fail-fast: false and no guard, slots on healthy runners complete independently.

Changes

  • Deleted src/devx/molecule/molecule_ci_guard.py and its test file
  • Moved get_running_jobs, any_other_runner_failed, and poll_for_other_failures inline into integration_guard.py
  • Removed molecule guard CLI command registration
  • Removed guard from doc_coverage.py REQUIRED_SCRIPTS
  • Removed 5 dead translation keys, added 1 missing key
  • Updated all tests, docs, and README

Test Results

1977 passed, 100% coverage. All pre-commit hooks passed.

Generated with Devin

## Summary The cross-runner cancellation guard (`molecule_ci_guard`) was killing healthy molecule slots when unhealthy slots failed on high-disk runners, defeating `fail-fast: false`. With `fail-fast: false` and no guard, slots on healthy runners complete independently. ## Changes - Deleted `src/devx/molecule/molecule_ci_guard.py` and its test file - Moved `get_running_jobs`, `any_other_runner_failed`, and `poll_for_other_failures` inline into `integration_guard.py` - Removed `molecule guard` CLI command registration - Removed guard from `doc_coverage.py` REQUIRED_SCRIPTS - Removed 5 dead translation keys, added 1 missing key - Updated all tests, docs, and README ## Test Results 1977 passed, 100% coverage. All pre-commit hooks passed. Generated with [Devin](https://devin.ai)
emil added 3 commits 2026-08-09 00:58:36 +00:00
refactor: remove molecule_ci_guard — adds complexity, no value
CI / validate (pull_request) Failing after 26s
CI / auto-merge (pull_request) Skipped
8e890437c8
The cross-runner cancellation guard was killing healthy molecule slots
when unhealthy slots failed, defeating fail-fast: false. With fail-fast:
false and no guard, slots on healthy runners complete independently.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
fix: remove dead translation keys and add missing one
CI / validate (pull_request) Failing after 56s
CI / auto-merge (pull_request) Skipped
a58092fc75
Remove 5 dead translation keys left over from molecule_ci_guard
removal. Add the missing "Another runner failed" key that
integration_guard.py references.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
chore: trigger CI after branch rename to DEVX-152
CI / validate (pull_request) Successful in 55s
CI / auto-merge (pull_request) Successful in 26s
d3897aea0d
emo reviewed 2026-08-09 00:59:29 +00:00
emo left a comment
Owner

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: OK
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.


Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: OK - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
emo approved these changes 2026-08-09 00:59:50 +00:00
emo left a comment
Owner

Auto-approved: all CI checks passed (validate job).

Auto-approved: all CI checks passed (validate job).
emo merged commit bd4530094e into master 2026-08-09 00:59:58 +00:00
emo deleted branch DEVX-152-remove-molecule-ci-guard 2026-08-09 01:00:01 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: oblachno-oss/devx#265