DEVX-141: Add promtool to install_tools for Prometheus alert rule validation #223

Merged
emil merged 0 commits from DEVX-141-promtool-install-tools into master 2026-07-14 23:18:30 +00:00
Owner

Summary

Add promtool (Prometheus 3.5.5 LTS) to the devx install_tools registry so it can be installed at runtime in CI via python3 -m devx.tools.install_tools --tool promtool.

Changes

  • Add PROMTOOL_VERSION = "3.5.5" (LTS release with promtool bug fixes)
  • Add install_promtool() function — downloads Prometheus tarball, extracts promtool binary to ~/.local/bin
  • Register promtool in TOOL_NAMES and _install_tool() dispatch
  • Update module docstring
  • Add TestInstallPromtool test class (3 tests: already_installed, install, url_contains_version)
  • Update test_install_all assertion (7 → 8 tools)
  • Add test_promtool to TestInstallTool

Testing

  • 1978 tests pass with 100% coverage
  • ruff, pyright, bandit all pass
  • Pre-commit hooks pass

Closes DEVX-141

## Summary Add promtool (Prometheus 3.5.5 LTS) to the devx install_tools registry so it can be installed at runtime in CI via `python3 -m devx.tools.install_tools --tool promtool`. ## Changes - Add `PROMTOOL_VERSION = "3.5.5"` (LTS release with promtool bug fixes) - Add `install_promtool()` function — downloads Prometheus tarball, extracts promtool binary to ~/.local/bin - Register promtool in `TOOL_NAMES` and `_install_tool()` dispatch - Update module docstring - Add `TestInstallPromtool` test class (3 tests: already_installed, install, url_contains_version) - Update `test_install_all` assertion (7 → 8 tools) - Add `test_promtool` to `TestInstallTool` ## Testing - 1978 tests pass with 100% coverage - ruff, pyright, bandit all pass - Pre-commit hooks pass Closes DEVX-141
emil reviewed 2026-07-14 23:18:07 +00:00
emil left a comment
Author
Owner

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: WARNING — source files changed but no docs updated
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.


Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: WARNING — source files changed but no docs updated - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
kireto approved these changes 2026-07-14 23:18:27 +00:00
kireto left a comment
Member

Auto-approved: all CI checks passed (validate job).

Auto-approved: all CI checks passed (validate job).
emil merged commit c62c560c85 into master 2026-07-14 23:18:30 +00:00
emil deleted branch DEVX-141-promtool-install-tools 2026-07-14 23:18:31 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: oblachno-oss/devx#223