DEVX-7: Make all warnings into errors in devx tools #17

Merged
emil merged 0 commits from DEVX-7-warnings-to-errors into master 2026-06-22 20:54:26 +00:00
Owner

Summary

Comprehensive audit of all devx CI tools, converting warnings to errors and adding missing input validation.

Changes by tool:

  • check_translations: Missing languages and dead keys are now errors (were warnings). Removed --strict flag. Fixed translations.json (removed 19 dead keys, added 11 missing keys, added 408 missing language entries).
  • post_merge: Non-infrastructure commits without task ID now raise (was warn+skip). Vikunja API errors now raise (was warn+return).
  • auto_merge: Missing VIKUNJA_TOKEN now raises (was silently skip). Added PR number and repo format validation.
  • release: Empty changelog now raises (was warn+continue). Added version format validation.
  • sync_wiki: Missing/empty mapped files now raise (was warn+skip). Added mapping.json structure validation.
  • discover_runners: Silent except: pass replaced with logged warnings.
  • api_clients: Bare except Exception replaced with specific exception types.
  • notify_failure: contextlib.suppress replaced with explicit try/except + logging.
  • molecule_ci_guard: Added pair format validation.
  • distribute_molecule: Added runner index bounds check.

All 821 tests pass with 100% coverage.

Closes DEVX-7

## Summary Comprehensive audit of all devx CI tools, converting warnings to errors and adding missing input validation. ### Changes by tool: - **check_translations**: Missing languages and dead keys are now errors (were warnings). Removed `--strict` flag. Fixed translations.json (removed 19 dead keys, added 11 missing keys, added 408 missing language entries). - **post_merge**: Non-infrastructure commits without task ID now raise (was warn+skip). Vikunja API errors now raise (was warn+return). - **auto_merge**: Missing VIKUNJA_TOKEN now raises (was silently skip). Added PR number and repo format validation. - **release**: Empty changelog now raises (was warn+continue). Added version format validation. - **sync_wiki**: Missing/empty mapped files now raise (was warn+skip). Added mapping.json structure validation. - **discover_runners**: Silent `except: pass` replaced with logged warnings. - **api_clients**: Bare `except Exception` replaced with specific exception types. - **notify_failure**: `contextlib.suppress` replaced with explicit try/except + logging. - **molecule_ci_guard**: Added pair format validation. - **distribute_molecule**: Added runner index bounds check. All 821 tests pass with 100% coverage. Closes DEVX-7
emil reviewed 2026-06-22 20:53:48 +00:00
emil left a comment
Author
Owner

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • i18n: OK
  • Resource management: OK
  • Documentation: WARNING — source files changed but no docs updated
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.


Auto-merge: If all CI checks pass, this PR will be merged automatically.

## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - i18n: OK - Resource management: OK - Documentation: WARNING — source files changed but no docs updated - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Auto-merge:** If all CI checks pass, this PR will be merged automatically.
emil merged commit 007e8dce9f into master 2026-06-22 20:54:26 +00:00
emil deleted branch DEVX-7-warnings-to-errors 2026-06-22 20:54:26 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: oblachno-oss/devx#17