oblachno-oss/devx

Public Access

DEVX-93: Audit fixes: bugs, dedup, tenacity adoption #148

Merged

emil merged 6 commits from DEVX-93-audit-fixes into master

2026-06-28 12:14:32 +00:00

Author	SHA1	Message	Date
emilandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	8a45b8254c	fix: remove --no-deps from setup-image to install new dependencies CI / detect-changes (pull_request) Successful in 12s Details CI / pr-review (pull_request) Successful in 12s Details CI / quality (pull_request) Successful in 40s Details CI / release-dry-run (pull_request) Successful in 11s Details CI / auto-merge (pull_request) Successful in 13s Details The setup-image target used 'pip install -e . --no-deps' which skips installing dependencies entirely. This meant newly added dependencies like tenacity were never installed in CI. Removing --no-deps allows pip to resolve and install all dependencies from pyproject.toml. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	2026-06-28 14:13:19 +02:00
emilandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	a047fcd084	fix: use source devx.mak instead of installed one in devx CI CI / release-dry-run (pull_request) Has been skipped Details CI / pr-review (pull_request) Failing after 9s Details CI / quality (pull_request) Failing after 11s Details CI / detect-changes (pull_request) Successful in 10s Details CI / auto-merge (pull_request) Has been skipped Details The CI Docker images have an older devx pre-installed in /opt/venv. The Makefile was loading devx.mak from that installed version, so fixes to src/devx/make/devx.mak (like the pip uninstall for new deps) were never picked up. Now we prefer the source devx.mak when it exists. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	2026-06-28 14:12:07 +02:00
emilandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	19e4a56e34	fix: uninstall devx before editable install in CI setup-image CI / detect-changes (pull_request) Successful in 11s Details CI / quality (pull_request) Failing after 13s Details CI / pr-review (pull_request) Failing after 10s Details CI / release-dry-run (pull_request) Has been skipped Details CI / auto-merge (pull_request) Has been skipped Details pip install -e . doesn't install new dependencies when the package is already installed (even with --upgrade). Uninstalling first forces pip to resolve all dependencies from scratch, picking up newly added ones like tenacity. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	2026-06-28 14:10:26 +02:00
emilandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	f647e1944f	fix: use --force-reinstall in setup-image for new dependencies CI / pr-review (pull_request) Failing after 9s Details CI / detect-changes (pull_request) Successful in 10s Details CI / quality (pull_request) Failing after 12s Details CI / release-dry-run (pull_request) Has been skipped Details CI / auto-merge (pull_request) Has been skipped Details pip install -e . doesn't install new dependencies when the package is already installed. --force-reinstall forces pip to re-resolve and reinstall all dependencies, including newly added ones like tenacity. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	2026-06-28 14:08:56 +02:00
emilandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	cef21e0e09	fix: force pip upgrade in setup-image to install new dependencies CI / quality (pull_request) Failing after 11s Details CI / pr-review (pull_request) Failing after 8s Details CI / detect-changes (pull_request) Successful in 9s Details CI / release-dry-run (pull_request) Has been skipped Details CI / auto-merge (pull_request) Has been skipped Details The CI Docker images are pre-built with devx and its deps baked in. When a new dependency is added (e.g. tenacity), pip install -e . in CI doesn't install it because the old metadata is cached. Adding --upgrade and --no-cache-dir forces pip to re-resolve dependencies. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	2026-06-28 14:07:39 +02:00
emilandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	cb2d2aadbd	refactor: adopt tenacity, extract shared utilities, fix critical bugs CI / pr-review (pull_request) Failing after 9s Details CI / detect-changes (pull_request) Successful in 11s Details CI / quality (pull_request) Failing after 13s Details CI / release-dry-run (pull_request) Has been skipped Details CI / auto-merge (pull_request) Has been skipped Details - Replace hand-rolled retry logic in GiteaClient/VikunjaClient with tenacity library (removes ~80 lines of duplicated code) - Extract duplicated utilities to ci/_shared.py: run_cmd, extract_task_id, write_github_env, write_github_output, lpt_distribute - Extract duplicated _arch() to tools/_shared.py: arch_string - Fix post_merge.py: hardcoded DEVX- prefix now uses TASK_PREFIX - Fix configure_repo.py: required_approvals 0→1 (matches AGENTS.md) - Fix check_auto_merge_ready.py: bare except Exception → except APIError - Add encoding="utf-8" to all text-mode open() calls - Add module docstring to molecule/__init__.py - Add missing docstrings to install_checkmake.py helpers - Fix pre-existing test bug in test_start_docker.py (os.environ.get mock replaced with patch.dict for subscript access) - Add venvPath/venv to pyright config for tenacity type resolution Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>	2026-06-28 14:05:03 +02:00