Emil Simeonov
6ede871054
- Remove console StreamHandler from get_logger() — say() already handles console output via click.echo(); having both caused every message to appear twice - Move GRM_LOG_LEVEL filtering into ui.say() via _console_level() so console verbosity is still user-controllable while the log file always captures everything at DEBUG - Remove [GRM] prefix from say() calls — no longer needed without duplicate logger output, giving cleaner user-facing messages - Update test_logging_config.py: remove console handler tests and _level_from_env tests (now in test_ui.py), expect 1 handler only - Add test_ui.py coverage for _console_level and say() level filtering - Update README to document single-path console output via click.echo - 116 tests, 100% coverage, pyright clean, ruff clean
66 lines
2.3 KiB
Python
66 lines
2.3 KiB
Python
"""Unit tests for user-facing output utilities."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from gitea_runner_manager.ui import _console_level, say
|
|
|
|
|
|
class TestConsoleLevel:
|
|
def test_default_is_info(self) -> None:
|
|
with patch.dict("os.environ", {}, clear=True):
|
|
assert _console_level() == logging.INFO
|
|
|
|
def test_env_override(self, monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setenv("GRM_LOG_LEVEL", "DEBUG")
|
|
assert _console_level() == logging.DEBUG
|
|
|
|
def test_invalid_fallback(self, monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setenv("GRM_LOG_LEVEL", "VERBOSE")
|
|
assert _console_level() == logging.INFO
|
|
|
|
|
|
class TestSay:
|
|
def test_echoes_to_console(self) -> None:
|
|
with patch("gitea_runner_manager.ui.click.echo") as mock_echo:
|
|
say("hello")
|
|
|
|
mock_echo.assert_called_once_with("hello", err=False)
|
|
|
|
def test_logs_at_info_level(self) -> None:
|
|
with (
|
|
patch("gitea_runner_manager.ui.click.echo"),
|
|
patch("gitea_runner_manager.ui.logging.getLogger") as mock_get_logger,
|
|
):
|
|
mock_logger = mock_get_logger.return_value
|
|
say("hello")
|
|
|
|
mock_logger.log.assert_called_once_with(logging.INFO, "hello")
|
|
|
|
def test_passes_level_and_err(self) -> None:
|
|
with (
|
|
patch("gitea_runner_manager.ui.click.echo") as mock_echo,
|
|
patch("gitea_runner_manager.ui.logging.getLogger") as mock_get_logger,
|
|
):
|
|
mock_logger = mock_get_logger.return_value
|
|
say("error msg", level=logging.ERROR, err=True)
|
|
|
|
mock_echo.assert_called_once_with("error msg", err=True)
|
|
mock_logger.log.assert_called_once_with(logging.ERROR, "error msg")
|
|
|
|
def test_suppresses_console_below_level(self, monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setenv("GRM_LOG_LEVEL", "WARNING")
|
|
with (
|
|
patch("gitea_runner_manager.ui.click.echo") as mock_echo,
|
|
patch("gitea_runner_manager.ui.logging.getLogger") as mock_get_logger,
|
|
):
|
|
mock_logger = mock_get_logger.return_value
|
|
say("debug msg", level=logging.DEBUG)
|
|
|
|
mock_echo.assert_not_called()
|
|
mock_logger.log.assert_called_once_with(logging.DEBUG, "debug msg")
|