oblachno-oss/grm
3
0
Fork 0
Code Issues 21 Pull Requests Actions Packages Projects Releases 15 Wiki Activity

fix: revert review_pr.py to GiteaClient (tea v0.14.1 is interactive-only) #70

Merged
emil merged 0 commits from GRM-54-fix-review-pr-fallback into master 2026-06-22 07:11:21 +00:00
Conversation 1 Commits - Files Changed -
emil commented 2026-06-22 07:09:01 +00:00
Owner
Copy Link
Copy Source

Summary

Fix for a limitation discovered after PR #68 was merged: the tea CLI v0.14.1 only supports interactive reviews (no --approve or --comment flags), so review_pr.py cannot use tea pulls review for posting reviews.

Changes

  • Revert scripts/ci/review_pr.py to use GiteaClient.create_review() instead of TeaCLI.review_pr()
  • Update tests/unit/test_review_pr.py to mock GiteaClient instead of TeaCLI
  • Update AGENTS.md to reflect that review_pr.py uses GiteaClient (tea v0.14.1 is interactive-only)
  • Update PYTHONPATH table in AGENTS.md to move review_pr.py back to src only

Note

The TeaCLI.review_pr() method remains in scripts/gitea_cli.py for future use when tea adds non-interactive review support.

All 838 tests pass with 100% coverage.

## Summary Fix for a limitation discovered after PR #68 was merged: the `tea` CLI v0.14.1 only supports interactive reviews (no `--approve` or `--comment` flags), so `review_pr.py` cannot use `tea pulls review` for posting reviews. ## Changes - Revert `scripts/ci/review_pr.py` to use `GiteaClient.create_review()` instead of `TeaCLI.review_pr()` - Update `tests/unit/test_review_pr.py` to mock `GiteaClient` instead of `TeaCLI` - Update `AGENTS.md` to reflect that `review_pr.py` uses `GiteaClient` (tea v0.14.1 is interactive-only) - Update PYTHONPATH table in `AGENTS.md` to move `review_pr.py` back to `src` only ## Note The `TeaCLI.review_pr()` method remains in `scripts/gitea_cli.py` for future use when tea adds non-interactive review support. All 838 tests pass with 100% coverage.
emil reviewed 2026-06-22 07:10:16 +00:00
emil left a comment
Author
Owner
Copy Link
Copy Source

Automated PR Review

  • Architecture compliance: OK
  • Best practices: OK
  • Security: OK
  • Documentation: OK
  • Tests: OK
  • Commit conventions: OK

No issues found by automated checks.

Manual review required: Before approving, review every category in
REVIEW_CHECKLIST.md and confirm with:

python3 scripts/ci/review_pr.py <PR> <owner/repo> \
  --event APPROVE --checklist-confirmed \
  --body "<substantive review summary>"
## Automated PR Review - Architecture compliance: OK - Best practices: OK - Security: OK - Documentation: OK - Tests: OK - Commit conventions: OK No issues found by automated checks. --- **Manual review required:** Before approving, review every category in [REVIEW_CHECKLIST.md](REVIEW_CHECKLIST.md) and confirm with: ```bash python3 scripts/ci/review_pr.py <PR> <owner/repo> \ --event APPROVE --checklist-confirmed \ --body "<substantive review summary>" ```
emil merged commit c03b349dd5 into master 2026-06-22 07:11:21 +00:00
emil deleted branch GRM-54-fix-review-pr-fallback 2026-06-22 07:11:21 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
emil
Labels
Clear labels
bug
Something is not working
 ci-improvement
CI workflow improvements
 doc-improvement
Documentation improvements
 feedback
Issues from subagent or agent feedback
 ready-to-merge
Auto-merge PR when all CI checks pass
 tooling
Tool-related feedback or improvements
 workflow-improvement
Workflow alignment or pattern improvements
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
emil (emil User) emo kireto
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: oblachno-oss/grm#70