Commit Graph
32 Commits
Author SHA1 Message Date
emil a7eb4d1a68 GRM-34: fix: install git-cliff to user-writable dir and fix archlinux idempotence 2026-06-21 13:18:54 +00:00
emil 1717d55013 GRM-32: fix: security, dead code, idempotence, and documentation cleanup
Post-merge Vikunja update / vikunja (push) Successful in 5s
CI / quality (push) Successful in 1m5s
CI / molecule-tests (0) (push) Successful in 18m37s
CI / molecule-tests (2) (push) Successful in 18m51s
CI / molecule-tests (1) (push) Successful in 19m6s
Publish Release / publish (push) Failing after 9s
2026-06-21 00:14:31 +00:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 3822f6fe9a fix: add default(0) to gitea_runner_uid in environment blocks
CI / quality (pull_request) Successful in 1m4s
CI / molecule-tests (2) (pull_request) Failing after 6m11s
CI / molecule-tests (1) (pull_request) Failing after 6m20s
CI / molecule-tests (0) (pull_request) Failing after 6m22s
Ansible evaluates environment blocks even when when conditions are
false. The deregister scenario sets skip_runner_registration: true
but the environment block still references gitea_runner_uid, causing
"variable is undefined" errors. Add default(0) filter to prevent
this.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-21 00:34:07 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> b7a04f37de fix: make user_setup and download tasks idempotent
CI / molecule-tests (2) (pull_request) Failing after 4m11s
CI / molecule-tests (1) (pull_request) Failing after 4m16s
CI / quality (pull_request) Successful in 1m6s
CI / molecule-tests (0) (pull_request) Failing after 4m9s
The "Enable lingering" task always reported changed=true, and the
"Download gitea_runner binary" task used force=true which always
re-downloads. Both caused molecule idempotence tests to fail.

- Check /var/lib/systemd/linger/<user> before enabling lingering
- Set force=false on get_url so binary is only downloaded if missing

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-21 00:13:19 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 8579a4064f fix: guard all systemctl --user tasks with docker_rootless_setup
CI / quality (pull_request) Successful in 1m4s
CI / molecule-tests (0) (pull_request) Failing after 3m26s
CI / molecule-tests (1) (pull_request) Failing after 3m26s
CI / molecule-tests (2) (pull_request) Failing after 3m14s
The daemon-reload, service restart, and service check tasks in
service.yml, prune.yml, update_runner.yml, and integration_test.yml
were not guarded by docker_rootless_setup. In CI containers without
a systemd user bus, these tasks fail with "Failed to connect to bus".

Also fix the integration_test.yml validation task to not fail on
service status when docker_rootless_setup is false.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-21 00:00:07 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 312b8241df fix: gate all Docker-dependent tasks behind docker_rootless_setup
CI / molecule-tests (2) (pull_request) Failing after 3m18s
CI / molecule-tests (0) (pull_request) Failing after 3m45s
CI / molecule-tests (1) (pull_request) Failing after 3m48s
CI / quality (pull_request) Successful in 1m6s
The validate.yml had an unconditional 'docker version' check, and
service.yml/prune.yml unconditionally enabled services that need
Docker running. Added when: docker_rootless_setup to:
- validate.yml: Verify rootless Docker connectivity
- service.yml: Enable and start gitea-runner service
- prune.yml: Enable and start docker-prune timer
Also made lifecycle side_effect tolerant of service start failure
since Docker daemon isn't available in molecule containers.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-20 22:50:25 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> da86eb0e9d fix: skip rootless Docker daemon startup in molecule tests
CI / quality (pull_request) Successful in 1m5s
CI / molecule-tests (0) (pull_request) Failing after 2m39s
CI / molecule-tests (1) (pull_request) Failing after 2m44s
CI / molecule-tests (2) (pull_request) Failing after 3m7s
Rootless Docker requires newuidmap/newgidmap kernel support which
doesn't work in nested Docker containers (Operation not permitted).
Added docker_rootless_setup variable (default true) to skip the
daemon startup steps. Set to false in all molecule converge playbooks
so tests verify package installation, user creation, service file
rendering, and config without requiring a working rootless daemon.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-20 22:37:31 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 084ea49523 fix: fail-fast CI, write Docker apt source directly, fix arch mapping
CI / molecule-tests (0) (pull_request) Failing after 2m32s
CI / molecule-tests (1) (pull_request) Failing after 2m52s
CI / quality (pull_request) Successful in 1m3s
CI / molecule-tests (2) (pull_request) Failing after 3m18s
Three changes:
1. CI: add set -e and fail-fast: true to stop on first molecule failure
   instead of continuing (all pairs fail for same reason anyway)
2. Docker APT repo: use copy module to write sources.list directly
   instead of apt_repository module which wasn't picking up the repo
3. Fix arch mapping: ansible_facts returns x86_64, Docker repo needs amd64

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-20 22:31:08 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 8af88efeb5 fix: add apt source debug tasks, fix arch mapping for Docker repo
CI / quality (pull_request) Successful in 1m2s
CI / molecule-tests (0) (pull_request) Failing after 1m59s
CI / molecule-tests (1) (pull_request) Failing after 2m23s
CI / molecule-tests (2) (pull_request) Failing after 2m32s
ansible_facts['architecture'] returns x86_64 but Docker APT repo
expects amd64. Added docker_apt_arch mapping. Also added debug tasks
to show apt sources and apt-cache search results for docker-ce.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-20 22:24:02 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 36207be565 fix: separate apt update after adding Docker repo, use variable for repo string
CI / molecule-tests (1) (pull_request) Failing after 2m8s
CI / quality (pull_request) Successful in 1m6s
CI / molecule-tests (0) (pull_request) Failing after 2m3s
CI / molecule-tests (2) (pull_request) Failing after 1m57s
The apt_repository update_cache option wasn't reliably picking up the
new Docker APT repo. Split into separate apt update step. Also moved
the long repo string to a default variable to satisfy yaml line-length
lint rule.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-20 22:15:28 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 119d70e137 fix: use bash for gpg dearmor (pipefail not available in sh)
CI / molecule-tests (0) (pull_request) Failing after 2m1s
CI / molecule-tests (2) (pull_request) Failing after 3m40s
CI / molecule-tests (1) (pull_request) Failing after 3m47s
CI / quality (pull_request) Successful in 1m3s
Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-20 21:57:24 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 74db5f28c7 fix: dearmor Docker GPG key with gpg --dearmor for apt_repository
CI / molecule-tests (2) (pull_request) Failing after 2m8s
CI / quality (pull_request) Successful in 1m3s
CI / molecule-tests (0) (pull_request) Failing after 1m59s
CI / molecule-tests (1) (pull_request) Failing after 2m25s
The deb822_repository module isn't available in the CI Ansible
collection. Reverted to apt_repository but now properly dearmors
the GPG key using gpg --dearmor before referencing it in signed-by.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-20 21:46:33 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 8aa00c7091 fix: use deb822_repository for Docker APT repo (proper GPG handling)
CI / quality (pull_request) Successful in 1m4s
CI / molecule-tests (2) (pull_request) Failing after 2m20s
CI / molecule-tests (0) (pull_request) Failing after 2m3s
CI / molecule-tests (1) (pull_request) Failing after 2m6s
The apt_repository module with signed-by wasn't working because the
downloaded GPG key wasn't properly dearmored. The deb822_repository
module handles GPG key download and dearmoring automatically.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-20 21:35:19 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 2a803c611b fix: add Docker APT repository before installing docker-ce
CI / quality (pull_request) Successful in 1m3s
CI / molecule-tests (2) (pull_request) Failing after 2m25s
CI / molecule-tests (0) (pull_request) Failing after 3m33s
CI / molecule-tests (1) (pull_request) Failing after 3m46s
The rootless_docker.yml task was trying to apt install docker-ce
without first adding the Docker APT repository, causing package not
found errors on Debian/Ubuntu containers.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-20 21:23:54 +02:00
Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 55c2746569 refactor: rootless Docker, fix auto-merge, molecule platform matrix
CI / molecule-tests (0) (pull_request) Has been skipped
CI / molecule-tests (1) (pull_request) Has been skipped
CI / molecule-tests (2) (pull_request) Has been skipped
CI / quality (pull_request) Failing after 1m4s
Three major improvements:

1. Rootless Docker refactor: Removes docker/binary modes, unifies to
   rootless Docker with per-runner system users. Each runner gets its
   own rootless Docker daemon, systemd user service, and isolated
   environment. Simplifies CLI (removes --mode option), Ansible role
   (single code path), and molecule scenarios (removes binary scenario).

2. Auto-merge fix: Fixes status check context mismatch in branch
   protection (was requiring "lint", "unit-tests", "molecule-tests" but
   actual contexts are "CI / quality", "CI / molecule-tests*"). Adds
   retry/wait logic to auto_merge.py that polls commit statuses for up
   to 15 minutes before attempting merge, eliminating the chicken-and-egg
   problem where auto-merge would fail because CI hadn't completed yet.

3. Molecule platform matrix: Adds OS platform matrix to CI — all 6
   scenarios now run on all 4 supported OSes (ubuntu-2204, ubuntu-2404,
   debian-12, archlinux) = 24 test pairs distributed across 3 parallel
   runners. Updates distribute_molecule.py to distribute (scenario,
   platform) pairs. Updates Makefile with molecule-all target for
   local multi-platform testing.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
2026-06-20 21:02:52 +02:00
emil 3364355c73 GRM-28: fix: Vikunja task resolution pagination in post_merge.py
Post-merge Vikunja update / vikunja (push) Failing after 8s
CI / quality (push) Successful in 1m5s
CI / molecule-tests (1) (push) Successful in 6m44s
CI / molecule-tests (2) (push) Successful in 7m7s
CI / molecule-tests (0) (push) Successful in 9m35s
2026-06-20 17:48:08 +00:00
emil ea18793963 GRM-26: fix: CI pipeline for rootless Docker runners
Post-merge Vikunja update / vikunja (push) Failing after 5s
CI / quality (push) Successful in 1m3s
CI / molecule-tests (2) (push) Successful in 6m57s
CI / molecule-tests (1) (push) Successful in 7m3s
CI / molecule-tests (0) (push) Successful in 9m17s
2026-06-20 16:16:05 +00:00
Emil Simeonov 129cfe3c79 GRM-20: fix molecule idempotence with mode-specific systemd templates
CI / lint (push) Has been cancelled
CI / unit-tests (push) Has been cancelled
CI / molecule-tests (push) Has been cancelled
2026-06-19 14:12:58 +02:00
Emil Simeonov c91626a8ff GRM-20: Ensure runner data directory exists in binary mode
CI / lint (push) Has been cancelled
CI / unit-tests (push) Has been cancelled
CI / molecule-tests (push) Has been cancelled
The binary_mode.yml task file did not create gitea_runner_data_dir
when runner registration was skipped (as in molecule tests). This
caused the binary scenario verify playbook to fail because the
data directory assertion expected it to exist.

Add an explicit directory creation step before config creation,
mirroring the docker_mode.yml structure.
2026-06-19 04:55:06 +02:00
Emil Simeonov e5964ca5a9 GRM-14: feat: add systemd template units and multi-instance Ansible support
- Add instance-scoped base data/config directories in defaults
- Create gitea-runner@.service.j2 template supporting Docker and binary modes
- Refactor service.yml to install systemd template unit instances
- Remove direct container lifecycle from docker_mode.yml (delegate to systemd)
- Add deregister.yml for runner deregistration on disable/remove
- Create lifecycle playbooks: start, stop, enable, disable, status, remove
- Update handlers, integration_test, docker_update, binary_update for template units
2026-06-18 22:59:04 +02:00
Emil Simeonov 6414f2306c GRM-13: fix: rewrite integration test to verify .runner file and container health instead of unreliable API checks 2026-06-18 09:34:45 +02:00
Emil Simeonov 1ad7c0a816 GRM-12: fix: convert runner config from TOML to YAML format 2026-06-18 04:47:41 +02:00
Emil Simeonov 9378451a12 GRM-12: fix: remove recursive var definitions from install-runner.yml 2026-06-18 04:40:11 +02:00
Emil Simeonov 81dd11e720 GRM-12: fix: make integration test conditional on admin API accessibility 2026-06-18 04:34:28 +02:00
Emil Simeonov a05cd1c7ee GRM-12: fix: set Docker working dir to /data for .runner persistence 2026-06-18 04:29:24 +02:00
Emil Simeonov 55fee77c91 GRM-11: fix: override Docker container entrypoint to bypass run.sh wrapper 2026-06-18 04:23:14 +02:00
Emil Simeonov b48038a3a9 GRM-10: fix: add timeout to runner registration to prevent indefinite hangs 2026-06-18 04:11:43 +02:00
Emil Simeonov 2530ec54cc GRM-6: fix: resolve idempotence issues and testing infrastructure 2026-06-18 03:36:20 +02:00
Emil Simeonov cc000c226c GRM-5: feat: parameterize all hardcoded configuration values as Ansible variables 2026-06-18 03:36:20 +02:00
Emil Simeonov 0cea9b9490 GRM-4: refactor: consolidate systemd checks and deduplicate role structure 2026-06-18 03:36:19 +02:00
Emil Simeonov b3838eb180 GRM-3: refactor: migrate source terminology from act_runner to gitea_runner 2026-06-18 03:36:19 +02:00
Emil Simeonov 170b53ad28 GRM-1: feat: initial implementation of Gitea Runner Manager 2026-06-17 18:15:28 +02:00