GRM-171: docs: add runner-ops, molecule-testing, vikunja-tasks skills, fix create-task docs
This commit was merged in pull request #278.
This commit is contained in:
@@ -0,0 +1,28 @@
|
||||
# GRM-171: Use kireto token for auto-merge approval review
|
||||
|
||||
## Problem
|
||||
The auto-merge workflow posts approval reviews with
|
||||
`REVIEWER_GITEA_API_TOKEN` (emil), but emil is also the PR creator.
|
||||
Gitea ignores self-approvals, so the merge fails with HTTP 405
|
||||
`Does not have enough approvals`.
|
||||
|
||||
## Approach
|
||||
REQ-1: Change the approval review step in `.gitea/workflows/ci.yml` to use
|
||||
`DEVELOPER_GITEA_API_TOKEN` (kireto) instead of
|
||||
`REVIEWER_GITEA_API_TOKEN` (emil), since kireto is a different user
|
||||
than the PR creator.
|
||||
|
||||
## Test Plan
|
||||
- `make lint-all` passes (workflow-lint validates the YAML)
|
||||
- Next auto-merge PR succeeds (approval posted by kireto, merge completes)
|
||||
|
||||
## Deploy Plan
|
||||
- Merge to master
|
||||
|
||||
## Rollback Plan
|
||||
- Revert the merge commit
|
||||
|
||||
## Acceptance Criteria
|
||||
- [x] REQ-1: Change the approval review step in `.gitea/workflows/ci.yml`
|
||||
to use `DEVELOPER_GITEA_API_TOKEN` (kireto) instead of
|
||||
`REVIEWER_GITEA_API_TOKEN` (emil)
|
||||
+39
-16
@@ -1,28 +1,51 @@
|
||||
# GRM-171: Use kireto token for auto-merge approval review
|
||||
# GRM-171: Add runner-ops, molecule-testing, vikunja-tasks skills, fix create-task docs
|
||||
|
||||
## Problem
|
||||
The auto-merge workflow posts approval reviews with
|
||||
`REVIEWER_GITEA_API_TOKEN` (emil), but emil is also the PR creator.
|
||||
Gitea ignores self-approvals, so the merge fails with HTTP 405
|
||||
`Does not have enough approvals`.
|
||||
|
||||
The OBL-INFRA-548 programme audit found grm lacks skills for runner
|
||||
fleet operations (needed for S08: leases, admission, watermarks),
|
||||
molecule scenario authoring, and Vikunja task lifecycle.
|
||||
`devx-workflow` and `AGENTS.md` document `make create-task -- --title`,
|
||||
which fails because `devx-create-task` forwards no arguments.
|
||||
|
||||
## Approach
|
||||
REQ-1: Change the approval review step in `.gitea/workflows/ci.yml` to use
|
||||
`DEVELOPER_GITEA_API_TOKEN` (kireto) instead of
|
||||
`REVIEWER_GITEA_API_TOKEN` (emil), since kireto is a different user
|
||||
than the PR creator.
|
||||
|
||||
REQ-1: Add `runner-ops` skill: RunnerManager/AnsibleExecutor model,
|
||||
stale-runner cleanup, image pruning, molecule container lifecycle,
|
||||
safe-debugging rules.
|
||||
REQ-2: Add `molecule-testing` skill: gitea_runner scenario layout,
|
||||
platform overrides, isolation flags, debugging.
|
||||
REQ-3: Add `vikunja-tasks` skill: create via module call, query,
|
||||
close, spec-collision convention.
|
||||
REQ-4: Fix broken `make create-task -- --title` documentation in
|
||||
`devx-workflow` skill and `AGENTS.md`.
|
||||
REQ-5: Add skill validation tests (`tests/unit/test_skills_validation.py`)
|
||||
+ fix stale make-target refs and missing sections in existing skills.
|
||||
|
||||
Preserve the colliding spec as
|
||||
[GRM-171-kireto-token-historical](GRM-171-kireto-token-historical.md).
|
||||
|
||||
## Test Plan
|
||||
- `make lint-all` passes (workflow-lint validates the YAML)
|
||||
- Next auto-merge PR succeeds (approval posted by kireto, merge completes)
|
||||
|
||||
- `pytest tests/unit/test_skills_validation.py` passes (12 tests).
|
||||
|
||||
## Deploy Plan
|
||||
- Merge to master
|
||||
|
||||
Documentation/skills only — auto-merge to master; no runtime deploy.
|
||||
|
||||
## Rollback Plan
|
||||
- Revert the merge commit
|
||||
|
||||
Revert the squash-merge commit; skills are inert documentation.
|
||||
|
||||
## Acceptance Criteria
|
||||
- [x] REQ-1: Change the approval review step in `.gitea/workflows/ci.yml`
|
||||
to use `DEVELOPER_GITEA_API_TOKEN` (kireto) instead of
|
||||
`REVIEWER_GITEA_API_TOKEN` (emil)
|
||||
|
||||
- [x] REQ-1: `runner-ops` skill exists.
|
||||
- [x] REQ-2: `molecule-testing` skill exists.
|
||||
- [x] REQ-3: `vikunja-tasks` skill exists.
|
||||
- [x] REQ-4: create-task docs corrected.
|
||||
- [x] REQ-5: Skill validation tests added and passing.
|
||||
|
||||
## Out of Scope
|
||||
|
||||
- Runner lease/admission implementation (S08 scope).
|
||||
- Fixing `devx-create-task` argument forwarding (devx repo, S11).
|
||||
|
||||
Reference in New Issue
Block a user