oblachno-oss/grm
3
0
Fork 0
Code Issues 31 Pull Requests Actions Packages Projects Releases 19 Wiki Activity

GRM-58: refactor: require tea CLI everywhere, fail on missing Vikunja task

Browse Source
This commit is contained in:
emil
2026-06-22 11:04:51 +00:00
parent 5e270f21d1
commit dcb2ed0fd9
11 changed files with 104 additions and 162 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/test_notify_failure.py
+15 -67
View File
@@ -1,20 +1,17 @@
"""Unit tests for scripts/ci/notify_failure.py."""
import http
from unittest.mock import MagicMock, patch
from click.testing import CliRunner
from gitea_runner_manager.exceptions import APIError
from scripts.ci.notify_failure import main
from scripts.gitea_cli import TeaCLIError
class TestNotifyFailure:
@patch.dict("os.environ", {"REPO_TOKEN": "tok"})
@patch("scripts.ci.notify_failure.shutil.which", return_value="/usr/bin/tea")
@patch("scripts.gitea_cli.TeaCLI")
def test_creates_issue_with_tea(self, mock_tea_cls: MagicMock, mock_which: MagicMock) -> None:
@patch("scripts.ci.notify_failure.TeaCLI")
def test_creates_issue_with_tea(self, mock_tea_cls: MagicMock) -> None:
mock_tea = MagicMock()
mock_tea.list_labels.return_value = [{"id": 5, "name": "bug"}]
mock_tea.create_issue.return_value = {"index": 42, "title": "test"}
@@ -40,9 +37,8 @@ class TestNotifyFailure:
mock_tea.add_label.assert_called_once_with("owner/repo", 42, ["bug"])
@patch.dict("os.environ", {"REPO_TOKEN": "tok"})
@patch("scripts.ci.notify_failure.shutil.which", return_value="/usr/bin/tea")
@patch("scripts.gitea_cli.TeaCLI")
def test_tea_creates_issue_without_bug_label(self, mock_tea_cls: MagicMock, mock_which: MagicMock) -> None:
@patch("scripts.ci.notify_failure.TeaCLI")
def test_tea_creates_issue_without_bug_label(self, mock_tea_cls: MagicMock) -> None:
mock_tea = MagicMock()
mock_tea.list_labels.return_value = [{"id": 1, "name": "enhancement"}]
mock_tea.create_issue.return_value = {"index": 43, "title": "test"}
@@ -58,72 +54,25 @@ class TestNotifyFailure:
mock_tea.add_label.assert_not_called()
@patch.dict("os.environ", {"REPO_TOKEN": "tok"})
@patch("scripts.ci.notify_failure.shutil.which", return_value="/usr/bin/tea")
@patch("scripts.gitea_cli.TeaCLI")
def test_tea_error_falls_back_to_client(self, mock_tea_cls: MagicMock, mock_which: MagicMock) -> None:
"""When tea fails, fall back to GiteaClient."""
@patch("scripts.ci.notify_failure.TeaCLI")
def test_tea_error_raises(self, mock_tea_cls: MagicMock) -> None:
"""When tea fails, the workflow fails — no fallback."""
mock_tea = MagicMock()
mock_tea.list_labels.side_effect = TeaCLIError("network error")
mock_tea.create_issue.side_effect = TeaCLIError("network error")
mock_tea_cls.return_value = mock_tea
with patch("scripts.ci.notify_failure.GiteaClient") as mock_client_cls:
mock_client = MagicMock()
mock_client.list_labels.return_value = [{"id": 5, "name": "bug"}]
mock_client.create_issue.return_value = {"id": 50}
mock_client_cls.return_value = mock_client
runner = CliRunner()
result = runner.invoke(
main,
["--repo", "owner/repo", "--run-id", "125", "--workflow", "release", "--commit", "abc"],
)
assert result.exit_code == 0
assert "issue #50" in result.output
mock_client.create_issue.assert_called_once()
@patch.dict("os.environ", {"REPO_TOKEN": "tok"})
@patch("scripts.ci.notify_failure.shutil.which", return_value=None)
@patch("scripts.ci.notify_failure.GiteaClient")
def test_tea_not_installed_uses_client(self, mock_client_cls: MagicMock, mock_which: MagicMock) -> None:
"""When tea is not installed, use GiteaClient directly."""
mock_client = MagicMock()
mock_client.list_labels.return_value = [{"id": 5, "name": "bug"}]
mock_client.create_issue.return_value = {"id": 51}
mock_client_cls.return_value = mock_client
runner = CliRunner()
result = runner.invoke(
main,
["--repo", "owner/repo", "--run-id", "126", "--workflow", "release", "--commit", "abc"],
["--repo", "owner/repo", "--run-id", "125", "--workflow", "release", "--commit", "abc"],
)
assert result.exit_code == 0
assert "issue #51" in result.output
mock_client.create_issue.assert_called_once()
assert result.exit_code != 0
assert "tea" in result.output.lower()
@patch.dict("os.environ", {"REPO_TOKEN": "tok"})
@patch("scripts.ci.notify_failure.shutil.which", return_value=None)
@patch("scripts.ci.notify_failure.GiteaClient")
def test_client_api_error_raises(self, mock_client_cls: MagicMock, mock_which: MagicMock) -> None:
mock_client = MagicMock()
mock_client.list_labels.return_value = []
mock_client.create_issue.side_effect = APIError(http.HTTPStatus.FORBIDDEN, "forbidden")
mock_client_cls.return_value = mock_client
runner = CliRunner()
result = runner.invoke(
main,
["--repo", "owner/repo", "--run-id", "127", "--workflow", "release", "--commit", "abc"],
)
assert result.exit_code == 1
assert "403" in result.output
@patch.dict("os.environ", {"REPO_TOKEN": "tok"})
@patch("scripts.ci.notify_failure.shutil.which", return_value="/usr/bin/tea")
@patch("scripts.gitea_cli.TeaCLI")
def test_tea_list_labels_error_continues_without_labels(
self, mock_tea_cls: MagicMock, mock_which: MagicMock
) -> None:
@patch("scripts.ci.notify_failure.TeaCLI")
def test_tea_list_labels_error_continues_without_labels(self, mock_tea_cls: MagicMock) -> None:
"""If listing labels fails via tea, issue is still created without labels."""
mock_tea = MagicMock()
mock_tea.list_labels.side_effect = TeaCLIError("network error")
@@ -139,9 +88,8 @@ class TestNotifyFailure:
assert "issue #50" in result.output
@patch.dict("os.environ", {"REPO_TOKEN": "tok"})
@patch("scripts.ci.notify_failure.shutil.which", return_value="/usr/bin/tea")
@patch("scripts.gitea_cli.TeaCLI")
def test_tea_add_label_error_is_ignored(self, mock_tea_cls: MagicMock, mock_which: MagicMock) -> None:
@patch("scripts.ci.notify_failure.TeaCLI")
def test_tea_add_label_error_is_ignored(self, mock_tea_cls: MagicMock) -> None:
"""If adding label fails via tea, issue is still reported as created."""
mock_tea = MagicMock()
mock_tea.list_labels.return_value = [{"id": 5, "name": "bug"}]
@@ -164,5 +112,5 @@ class TestNotifyFailure:
main,
["--repo", "owner/repo", "--run-id", "1", "--workflow", "release", "--commit", "abc"],
)
assert result.exit_code == 1
assert result.exit_code != 0
assert "REPO_TOKEN" in result.output