oblachno-oss/grm
3
0
Fork 0
Code Issues 31 Pull Requests Actions Packages Projects Releases 19 Wiki Activity

GRM-3: refactor: migrate source terminology from act_runner to gitea_runner

Browse Source
This commit is contained in:
Emil Simeonov
2026-06-18 03:36:19 +02:00
parent 3c8654342f
commit b3838eb180
10 changed files with 295 additions and 214 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/test_cli.py
+109 -83
View File
@@ -14,89 +14,47 @@ class TestCLI:
assert result.exit_code == 0
assert "0.1.0" in result.output
@patch("gitea_runner_manager.cli.GiteaAPIClient")
@patch("gitea_runner_manager.cli.RunnerManager")
def test_list_runners(self, mock_manager_class: MagicMock, mock_client_class: MagicMock) -> None:
mock_client = MagicMock()
mock_client_class.from_env.return_value = mock_client
def test_install(self, mock_manager_class: MagicMock) -> None:
mock_manager = MagicMock()
mock_manager.list_runners.return_value = [
{"id": 1, "name": "runner1", "status": "online"},
]
mock_manager_class.return_value = mock_manager
runner = CliRunner()
result = runner.invoke(cli, ["list"])
runner = CliRunner(env={"GITEA_URL": "https://git.example.com"})
result = runner.invoke(cli, ["install", "host1", "--user", "ubuntu", "--token", "tok"])
assert result.exit_code == 0
assert "runner1" in result.output
assert "online" in result.output
mock_manager.install.assert_called_once_with(
host="host1",
user="ubuntu",
key=None,
name=None,
token="tok",
gitea_url="https://git.example.com",
mode="docker",
ask_become_pass=False,
)
@patch("gitea_runner_manager.cli.GiteaAPIClient")
@patch("gitea_runner_manager.cli.RunnerManager")
def test_list_empty(self, mock_manager_class: MagicMock, mock_client_class: MagicMock) -> None:
mock_client = MagicMock()
mock_client_class.from_env.return_value = mock_client
mock_manager = MagicMock()
mock_manager.list_runners.return_value = []
mock_manager_class.return_value = mock_manager
def test_install_missing_url(self, mock_manager_class: MagicMock) -> None:
with patch.dict("os.environ", {"GITEA_REGISTRATION_TOKEN": "tok"}, clear=True):
runner = CliRunner()
result = runner.invoke(cli, ["install", "host1", "--user", "ubuntu", "--token", "tok"])
assert result.exit_code != 0
assert "GITEA_URL must be set" in result.output
runner = CliRunner()
result = runner.invoke(cli, ["list"])
assert result.exit_code == 0
assert "No runners found" in result.output
@patch("gitea_runner_manager.cli.GiteaAPIClient")
@patch("gitea_runner_manager.cli.RunnerManager")
def test_token(self, mock_manager_class: MagicMock, mock_client_class: MagicMock) -> None:
mock_client = MagicMock()
mock_client_class.from_env.return_value = mock_client
mock_manager = MagicMock()
mock_manager.generate_token.return_value = "tok123"
mock_manager_class.return_value = mock_manager
def test_install_missing_token(self, mock_manager_class: MagicMock) -> None:
with patch.dict("os.environ", {"GITEA_URL": "https://git.example.com"}, clear=True):
runner = CliRunner()
result = runner.invoke(cli, ["install", "host1", "--user", "ubuntu"])
assert result.exit_code != 0
assert "GITEA_REGISTRATION_TOKEN must be set" in result.output
runner = CliRunner()
result = runner.invoke(cli, ["token"])
assert result.exit_code == 0
assert "tok123" in result.output
@patch("gitea_runner_manager.cli.GiteaAPIClient")
@patch("gitea_runner_manager.cli.RunnerManager")
def test_token_error(self, mock_manager_class: MagicMock, mock_client_class: MagicMock) -> None:
mock_client = MagicMock()
mock_client_class.from_env.return_value = mock_client
mock_manager = MagicMock()
from gitea_runner_manager.exceptions import GiteaAPIError
mock_manager.generate_token.side_effect = GiteaAPIError("boom")
mock_manager_class.return_value = mock_manager
runner = CliRunner()
result = runner.invoke(cli, ["token"])
assert result.exit_code != 0
assert "boom" in result.output
@patch("gitea_runner_manager.cli.GiteaAPIClient")
@patch("gitea_runner_manager.cli.RunnerManager")
def test_install(self, mock_manager_class: MagicMock, mock_client_class: MagicMock) -> None:
mock_client = MagicMock()
mock_client_class.from_env.return_value = mock_client
def test_install_with_options(self, mock_manager_class: MagicMock) -> None:
mock_manager = MagicMock()
mock_manager_class.return_value = mock_manager
runner = CliRunner()
result = runner.invoke(cli, ["install", "host1", "--user", "ubuntu"])
assert result.exit_code == 0
mock_manager.install.assert_called_once_with(host="host1", user="ubuntu", key=None, name=None, token=None)
@patch("gitea_runner_manager.cli.GiteaAPIClient")
@patch("gitea_runner_manager.cli.RunnerManager")
def test_install_with_options(self, mock_manager_class: MagicMock, mock_client_class: MagicMock) -> None:
mock_client = MagicMock()
mock_client_class.from_env.return_value = mock_client
mock_manager = MagicMock()
mock_manager_class.return_value = mock_manager
runner = CliRunner()
runner = CliRunner(env={"GITEA_URL": "https://git.example.com"})
result = runner.invoke(
cli,
[
@@ -119,29 +77,64 @@ class TestCLI:
key="/key",
name="r1",
token="tok",
gitea_url="https://git.example.com",
mode="docker",
ask_become_pass=False,
)
@patch("gitea_runner_manager.cli.GiteaAPIClient")
@patch("gitea_runner_manager.cli.RunnerManager")
def test_install_error(self, mock_manager_class: MagicMock, mock_client_class: MagicMock) -> None:
mock_client = MagicMock()
mock_client_class.from_env.return_value = mock_client
def test_install_ask_become_pass(self, mock_manager_class: MagicMock) -> None:
mock_manager = MagicMock()
mock_manager_class.return_value = mock_manager
runner = CliRunner(env={"GITEA_URL": "https://git.example.com"})
result = runner.invoke(cli, ["install", "host1", "--user", "ubuntu", "--token", "tok", "--ask-become-pass"])
assert result.exit_code == 0
mock_manager.install.assert_called_once_with(
host="host1",
user="ubuntu",
key=None,
name=None,
token="tok",
gitea_url="https://git.example.com",
mode="docker",
ask_become_pass=True,
)
@patch("gitea_runner_manager.cli.RunnerManager")
def test_install_binary_mode(self, mock_manager_class: MagicMock) -> None:
mock_manager = MagicMock()
mock_manager_class.return_value = mock_manager
runner = CliRunner(env={"GITEA_URL": "https://git.example.com"})
result = runner.invoke(cli, ["install", "host1", "--user", "ubuntu", "--token", "tok", "--mode", "binary"])
assert result.exit_code == 0
mock_manager.install.assert_called_once_with(
host="host1",
user="ubuntu",
key=None,
name=None,
token="tok",
gitea_url="https://git.example.com",
mode="binary",
ask_become_pass=False,
)
@patch("gitea_runner_manager.cli.RunnerManager")
def test_install_error(self, mock_manager_class: MagicMock) -> None:
mock_manager = MagicMock()
from gitea_runner_manager.exceptions import AnsibleError
mock_manager.install.side_effect = AnsibleError("fail")
mock_manager_class.return_value = mock_manager
runner = CliRunner()
result = runner.invoke(cli, ["install", "host1", "--user", "ubuntu"])
runner = CliRunner(env={"GITEA_URL": "https://git.example.com"})
result = runner.invoke(cli, ["install", "host1", "--user", "ubuntu", "--token", "tok"])
assert result.exit_code != 0
assert "fail" in result.output
@patch("gitea_runner_manager.cli.GiteaAPIClient")
@patch("gitea_runner_manager.cli.RunnerManager")
def test_update(self, mock_manager_class: MagicMock, mock_client_class: MagicMock) -> None:
mock_client = MagicMock()
mock_client_class.from_env.return_value = mock_client
def test_update(self, mock_manager_class: MagicMock) -> None:
mock_manager = MagicMock()
mock_manager_class.return_value = mock_manager
@@ -165,13 +158,46 @@ class TestCLI:
user="ubuntu",
key="/key",
version="v0.2.0",
mode="docker",
ask_become_pass=False,
)
@patch("gitea_runner_manager.cli.GiteaAPIClient")
@patch("gitea_runner_manager.cli.RunnerManager")
def test_update_error(self, mock_manager_class: MagicMock, mock_client_class: MagicMock) -> None:
mock_client = MagicMock()
mock_client_class.from_env.return_value = mock_client
def test_update_ask_become_pass(self, mock_manager_class: MagicMock) -> None:
mock_manager = MagicMock()
mock_manager_class.return_value = mock_manager
runner = CliRunner()
result = runner.invoke(cli, ["update", "host1", "--user", "ubuntu", "--ask-become-pass"])
assert result.exit_code == 0
mock_manager.update.assert_called_once_with(
host="host1",
user="ubuntu",
key=None,
version=None,
mode="docker",
ask_become_pass=True,
)
@patch("gitea_runner_manager.cli.RunnerManager")
def test_update_binary_mode(self, mock_manager_class: MagicMock) -> None:
mock_manager = MagicMock()
mock_manager_class.return_value = mock_manager
runner = CliRunner()
result = runner.invoke(cli, ["update", "host1", "--user", "ubuntu", "--mode", "binary"])
assert result.exit_code == 0
mock_manager.update.assert_called_once_with(
host="host1",
user="ubuntu",
key=None,
version=None,
mode="binary",
ask_become_pass=False,
)
@patch("gitea_runner_manager.cli.RunnerManager")
def test_update_error(self, mock_manager_class: MagicMock) -> None:
mock_manager = MagicMock()
from gitea_runner_manager.exceptions import AnsibleError
tests/unit/test_runner_manager.py
+70 -43
View File
@@ -5,35 +5,21 @@ from unittest.mock import MagicMock, patch
import pytest
from gitea_runner_manager.api_client import GiteaAPIClient
from gitea_runner_manager.exceptions import AnsibleError
from gitea_runner_manager.runner_manager import RunnerManager
class TestRunnerManager:
def test_list_runners(self) -> None:
api = MagicMock(spec=GiteaAPIClient)
api.get_runners.return_value = [{"id": 1, "name": "r1"}]
manager = RunnerManager(api)
runners = manager.list_runners()
assert runners == [{"id": 1, "name": "r1"}]
def test_init(self) -> None:
manager = RunnerManager()
assert manager is not None
def test_generate_token(self) -> None:
api = MagicMock(spec=GiteaAPIClient)
api.create_registration_token.return_value = "token123"
manager = RunnerManager(api)
token = manager.generate_token()
assert token == "token123"
def test_install_without_name_or_token(self) -> None:
api = MagicMock(spec=GiteaAPIClient)
api.base_url = "https://git.example.com"
api.create_registration_token.return_value = "auto-token"
manager = RunnerManager(api)
def test_install_basic(self) -> None:
manager = RunnerManager()
with patch("subprocess.run") as mock_run:
mock_run.return_value = MagicMock(returncode=0)
manager.install("192.168.1.10", "ubuntu")
manager.install("192.168.1.10", "ubuntu", token="tok", gitea_url="https://git.example.com")
mock_run.assert_called_once()
cmd = mock_run.call_args[0][0]
cmd_str = " ".join(cmd)
@@ -41,47 +27,69 @@ class TestRunnerManager:
assert "192.168.1.10," in cmd_str
assert "-u" in cmd_str
assert "ubuntu" in cmd_str
assert "registration_token=auto-token" in cmd_str
assert "registration_token=tok" in cmd_str
assert "runner_name=192.168.1.10" in cmd_str
assert "gitea_url=https://git.example.com" in cmd_str
assert "runner_mode=docker" in cmd_str
def test_install_with_name_and_token(self) -> None:
api = MagicMock(spec=GiteaAPIClient)
api.base_url = "https://git.example.com"
manager = RunnerManager(api)
def test_install_with_name_and_key(self) -> None:
manager = RunnerManager()
with patch("subprocess.run") as mock_run:
mock_run.return_value = MagicMock(returncode=0)
manager.install("host1", "root", key="/key", name="my-runner", token="preset")
manager.install(
"host1", "root", key="/key", name="my-runner", token="preset", gitea_url="https://git.example.com"
)
cmd = mock_run.call_args[0][0]
cmd_str = " ".join(cmd)
assert "--private-key" in cmd_str
assert "/key" in cmd_str
assert "registration_token=preset" in cmd_str
assert "runner_name=my-runner" in cmd_str
api.create_registration_token.assert_not_called()
assert "runner_mode=docker" in cmd_str
assert "--ask-become-pass" not in cmd_str
def test_install_ask_become_pass(self) -> None:
manager = RunnerManager()
with patch("subprocess.run") as mock_run:
mock_run.return_value = MagicMock(returncode=0)
manager.install("host1", "root", token="tok", gitea_url="https://git.example.com", ask_become_pass=True)
cmd = mock_run.call_args[0][0]
cmd_str = " ".join(cmd)
assert "--ask-become-pass" in cmd_str
assert "runner_mode=docker" in cmd_str
def test_install_binary_mode(self) -> None:
manager = RunnerManager()
with patch("subprocess.run") as mock_run:
mock_run.return_value = MagicMock(returncode=0)
manager.install("host1", "root", token="tok", gitea_url="https://git.example.com", mode="binary")
cmd = mock_run.call_args[0][0]
cmd_str = " ".join(cmd)
assert "runner_mode=binary" in cmd_str
def test_install_missing_token(self) -> None:
manager = RunnerManager()
with pytest.raises(AnsibleError, match="GITEA_REGISTRATION_TOKEN must be set"):
manager.install("host", "user", gitea_url="https://git.example.com")
def test_install_playbook_not_found(self) -> None:
api = MagicMock(spec=GiteaAPIClient)
api.base_url = "https://git.example.com"
manager = RunnerManager(api)
manager = RunnerManager()
with patch.object(Path, "exists", return_value=False):
with pytest.raises(AnsibleError, match="Playbook not found"):
manager.install("host", "user")
manager.install("host", "user", token="tok")
def test_install_ansible_failure(self) -> None:
api = MagicMock(spec=GiteaAPIClient)
api.base_url = "https://git.example.com"
api.create_registration_token.return_value = "tok"
manager = RunnerManager(api)
manager = RunnerManager()
with patch("subprocess.run") as mock_run:
mock_run.return_value = MagicMock(returncode=1)
with pytest.raises(AnsibleError, match="Ansible failed with exit code 1"):
manager.install("host", "user")
manager.install("host", "user", token="tok")
def test_update(self) -> None:
api = MagicMock(spec=GiteaAPIClient)
manager = RunnerManager(api)
manager = RunnerManager()
with patch("subprocess.run") as mock_run:
mock_run.return_value = MagicMock(returncode=0)
manager.update("host", "user", key="/key", version="v0.2.0")
@@ -90,18 +98,37 @@ class TestRunnerManager:
assert "update-runner.yml" in cmd_str
assert "--private-key" in cmd_str
assert "/key" in cmd_str
assert "act_runner_version=v0.2.0" in cmd_str
assert "gitea_runner_version=v0.2.0" in cmd_str
assert "runner_mode=docker" in cmd_str
assert "--ask-become-pass" not in cmd_str
def test_update_ask_become_pass(self) -> None:
manager = RunnerManager()
with patch("subprocess.run") as mock_run:
mock_run.return_value = MagicMock(returncode=0)
manager.update("host", "user", ask_become_pass=True)
cmd = mock_run.call_args[0][0]
cmd_str = " ".join(cmd)
assert "--ask-become-pass" in cmd_str
assert "runner_mode=docker" in cmd_str
def test_update_binary_mode(self) -> None:
manager = RunnerManager()
with patch("subprocess.run") as mock_run:
mock_run.return_value = MagicMock(returncode=0)
manager.update("host", "user", mode="binary")
cmd = mock_run.call_args[0][0]
cmd_str = " ".join(cmd)
assert "runner_mode=binary" in cmd_str
def test_update_playbook_not_found(self) -> None:
api = MagicMock(spec=GiteaAPIClient)
manager = RunnerManager(api)
manager = RunnerManager()
with patch.object(Path, "exists", return_value=False):
with pytest.raises(AnsibleError, match="Playbook not found"):
manager.update("host", "user")
def test_update_ansible_failure(self) -> None:
api = MagicMock(spec=GiteaAPIClient)
manager = RunnerManager(api)
manager = RunnerManager()
with patch("subprocess.run") as mock_run:
mock_run.return_value = MagicMock(returncode=2)
with pytest.raises(AnsibleError, match="Ansible failed with exit code 2"):