GRM-171: fix: use kireto token for auto-merge approval review
Co-authored-by: emil User <emil.simeonov@tutanota.com>
This commit was merged in pull request #267.
This commit is contained in:
@@ -0,0 +1,28 @@
|
||||
# GRM-171: Use kireto token for auto-merge approval review
|
||||
|
||||
## Problem
|
||||
The auto-merge workflow posts approval reviews with
|
||||
`REVIEWER_GITEA_API_TOKEN` (emil), but emil is also the PR creator.
|
||||
Gitea ignores self-approvals, so the merge fails with HTTP 405
|
||||
`Does not have enough approvals`.
|
||||
|
||||
## Approach
|
||||
REQ-1: Change the approval review step in `.gitea/workflows/ci.yml` to use
|
||||
`DEVELOPER_GITEA_API_TOKEN` (kireto) instead of
|
||||
`REVIEWER_GITEA_API_TOKEN` (emil), since kireto is a different user
|
||||
than the PR creator.
|
||||
|
||||
## Test Plan
|
||||
- `make lint-all` passes (workflow-lint validates the YAML)
|
||||
- Next auto-merge PR succeeds (approval posted by kireto, merge completes)
|
||||
|
||||
## Deploy Plan
|
||||
- Merge to master
|
||||
|
||||
## Rollback Plan
|
||||
- Revert the merge commit
|
||||
|
||||
## Acceptance Criteria
|
||||
- [x] REQ-1: Change the approval review step in `.gitea/workflows/ci.yml`
|
||||
to use `DEVELOPER_GITEA_API_TOKEN` (kireto) instead of
|
||||
`REVIEWER_GITEA_API_TOKEN` (emil)
|
||||
Reference in New Issue
Block a user