GRM-50: fix: workflow timing, timeouts, status polling, and release classification

2026-06-22 00:44:35 +00:00
parent 789890b9ea
commit 7591c99c02
20 changed files with 333 additions and 78 deletions
@@ -77,14 +77,61 @@ class TestMain:
    @patch.dict("os.environ", {"REPO_TOKEN": "tok"})
    @patch("scripts.ci.review_pr.GiteaClient")
    def test_successful_approve_review(self, mock_client_cls: MagicMock) -> None:
+        """APPROVE requires --checklist-confirmed and substantive body."""
        mock_client = MagicMock()
        mock_client.create_review.return_value = {"id": 7}
        mock_client_cls.return_value = mock_client
        runner = CliRunner()
-        result = runner.invoke(main, ["5", "owner/repo", "--event", "APPROVE"])
+        result = runner.invoke(
+            main,
+            [
+                "5",
+                "owner/repo",
+                "--event",
+                "APPROVE",
+                "--checklist-confirmed",
+                "--body",
+                "All 10 checklist categories verified. Architecture OK, tests pass.",
+            ],
+        )
        assert result.exit_code == 0
        assert "Review #7" in result.output
-        mock_client.create_review.assert_called_once_with("5", event="APPROVE", body="", comments=[])
+        mock_client.create_review.assert_called_once_with(
+            "5",
+            event="APPROVE",
+            body="All 10 checklist categories verified. Architecture OK, tests pass.",
+            comments=[],
+        )
+
+    @patch.dict("os.environ", {"REPO_TOKEN": "tok"})
+    @patch("scripts.ci.review_pr.GiteaClient")
+    def test_approve_without_checklist_confirmed_fails(self, mock_client_cls: MagicMock) -> None:
+        """APPROVE without --checklist-confirmed is rejected."""
+        mock_client = MagicMock()
+        mock_client_cls.return_value = mock_client
+        runner = CliRunner()
+        result = runner.invoke(
+            main,
+            ["5", "owner/repo", "--event", "APPROVE", "--body", "Looks good to me"],
+        )
+        assert result.exit_code != 0
+        assert "checklist" in result.output.lower()
+        mock_client.create_review.assert_not_called()
+
+    @patch.dict("os.environ", {"REPO_TOKEN": "tok"})
+    @patch("scripts.ci.review_pr.GiteaClient")
+    def test_approve_with_trivial_body_fails(self, mock_client_cls: MagicMock) -> None:
+        """APPROVE with trivial body (< 20 chars) and no comments is rejected."""
+        mock_client = MagicMock()
+        mock_client_cls.return_value = mock_client
+        runner = CliRunner()
+        result = runner.invoke(
+            main,
+            ["5", "owner/repo", "--event", "APPROVE", "--checklist-confirmed", "--body", "LGTM"],
+        )
+        assert result.exit_code != 0
+        assert "substantive" in result.output.lower()
+        mock_client.create_review.assert_not_called()

    @patch.dict("os.environ", {"REPO_TOKEN": "tok"})
    @patch("scripts.ci.review_pr.GiteaClient")