GRM-132: ci: bump devx to 0.33.0, use devx-check-api-identity-checks

2026-07-05 15:07:03 +00:00
parent e30acbe213
commit 5a93559b79
5 changed files with 46 additions and 5 deletions
@@ -433,6 +433,23 @@ Change classification is config-driven via `[tool.devx.classify]` in `pyproject.
 - Secrets are passed via temp JSON files, never on the command line (CWE-214)
 - CI triggers only on `opened` and `synchronize` PR events (not `labeled`)

+### Testing Conventions
+
+- **Always run `make pytest-cov` before pushing** — CI enforces 100%
+  coverage and will fail the PR if any lines are uncovered. The pre-push
+  hook only validates Vikunja task existence, not tests.
+- **Never use `is True`/`is False` identity checks on API response
+  values** — many APIs return boolean values as strings (`"true"`/
+  `"false"`). Use string comparison or truthy/falsy helpers instead.
+- **Always mock `time.sleep` and `time.monotonic` in unit tests** — real
+  sleep calls make tests slow and exceed test speed limits. Use
+  `@patch("time.sleep")` and `@patch("time.monotonic")` decorators.
+- **Extract complex inline shell from workflows to tested Python tools**
+  — SSH loops, curl polling, docker exec chains, and multi-line
+  if/then/else shell blocks should be Python scripts in `scripts/`
+  with unit tests. Simple variable checks and venv activation are fine
+  as inline shell.
+
 ### Container-Level Fix Verification (Mandatory)

 **Rule:** Before pushing any fix that modifies container state (CA certs,