oblachno-oss/devx

Public Access

Fork 0

Files

T

Emil SimeonovandDevin <158243242+devin-ai-integration[bot]@users.noreply.github.com> 0c21e4c82f

CI / validate (pull_request) Successful in 46s

Details

CI / auto-merge (pull_request) Successful in 11s

Details

fix(ci): handle list-shaped ref response in create_dependency_pr

Gitea GET /git/refs/heads/master returns a JSON array of matching refs,
not an object — crashed with AttributeError and blocked automated infra
dependency PRs (observed for sso-bridge v0.4.1).

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

2026-09-19 21:04:38 +02:00

1.1 KiB

Raw Blame History

DEVX-168: Fix create_dependency_pr master-ref parsing

Problem

devx.ci.create_dependency_pr crashes with AttributeError: 'list' object has no attribute 'get' when creating the dependency branch. Gitea's GET /repos/{o}/{r}/git/refs/heads/master returns a JSON array of matching refs, not a single object. Observed in production when sso-bridge v0.4.1's post-merge dep-PR step ran.

Approach

REQ-1: Normalize the ref response — if it is a list, select the entry whose ref field equals refs/heads/master or fall back to the first entry; proceed to extract object.sha as before. An empty or absent SHA still fails closed.

Test Plan

Unit test: list-shaped response resolves SHA and creates the PR.
Unit test: empty list fails with the master-SHA error message.

Deploy Plan

devx releases as a version tag; sso-bridge/infra pin bumps pick it up via their normal dep-PR flow.

Rollback Plan

Revert the commit; dep-PR creation stays broken on Gitea (status quo).

Acceptance Criteria

REQ-1: list-shaped ref response is handled; SHA extraction works; empty list still errors. Covered by unit tests at 100% coverage.

1.1 KiB Raw Blame History