oblachno-oss/devx
Public Access
3
0
Fork 0
Code Issues 90 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

DEVX-162: Fix Gitea repo-variable read contract (data field) and fail closed on unknown nightly status #319

Merged
kireto merged 4 commits from DEVX-162-variable-data-field into master 2026-09-17 09:41:38 +00:00
Conversation 1 Commits 4 Files Changed 7
+10 -8
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 23e19f9406 - Show all commits
docs/specs/DEVX-162.md
+10 -8
View File
@@ -24,14 +24,16 @@ race) is preserved as `DEVX-162-registry-push-race-historical.md`.
## Approach
1. REQ-1: `src/devx/api_clients.py` — `get_repo_variable` reads `data` first
and falls back to `value` for older server/fixture compatibility. Write
path unchanged (PUT/POST `{"value": ...}` verified live: 201/204).
2. REQ-2: `src/devx/ci/nightly_gate.py` — unknown non-empty status blocks the
deploy (fail closed) instead of allowing it. Unset (bootstrap) still
allows.
3. REQ-3: Tests cover the `data` field, the `value` fallback, and fail-closed
unknown status.
REQ-1: `src/devx/api_clients.py` — `get_repo_variable` reads `data` first
and falls back to `value` for older server/fixture compatibility. Write
path unchanged (PUT/POST `{"value": ...}` verified live: 201/204).
REQ-2: `src/devx/ci/nightly_gate.py` — unknown non-empty status blocks the
deploy (fail closed) instead of allowing it. Unset (bootstrap) still
allows.
REQ-3: Tests cover the `data` field, the `value` fallback, and fail-closed
unknown status.
## Test Plan