emil
changed title from DEVX-136: enhance check_test_isolation with transitive subprocess detection to DEVX-136: Enhance check_test_isolation with transitive subprocess detection2026-07-13 23:50:36 +00:00
Auto-merge: If all CI checks pass, this PR will be merged automatically.
## Automated PR Review
- Architecture compliance: OK
- Best practices: OK
- Security: OK
- i18n: OK
- Resource management: OK
- Documentation: OK
- Tests: OK
- Commit conventions: OK
No issues found by automated checks.
---
**Auto-merge:** If all CI checks pass, this PR will be merged automatically.
kireto
approved these changes 2026-07-13 23:53:52 +00:00
- New devx.ci.fix_pr_title module: auto-fixes PR title to follow
the {PREFIX}-N: <title> convention by fetching task ID from branch
name and Vikunja task title. Supports --dry-run for safe preview.
Falls back to stripping conventional-commit prefixes from current
title when Vikunja task is not found.
- New GiteaClient.update_pr() method for PATCH /pulls/{n} API calls
- Added remediation hint to check_auto_merge_ready error output:
when PR title format errors are detected, prints the exact
fix_pr_title command to run
- Tests: 8 new tests for fix_pr_title, 1 new test for update_pr
This addresses the root cause of repeated validate CI failures where
PR titles were created without the task ID prefix. The remediation
hint in the error message now tells the user exactly how to fix it.
Generated with [Devin](https://devin.ai)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Improve the static analysis call graph to detect transitive subprocess
calls through helper functions. Key changes:
- Stop adding KNOWN_SUBPROCESS_HELPERS to subprocess_calls directly;
they are traversed via the call graph BFS instead, eliminating false
positives when helpers are transitively patched (e.g. run_cmd patched
→ run_tests is safe).
- Skip class methods in call graph registration to avoid false positives
when classes are patched (e.g. @patch("TeaCLI") mocks all methods).
- Fix _is_patched to use exact endswith matching instead of substring,
preventing "run" from matching "run_cmd".
- Add patch.object() and with patch() context manager support to
_extract_patch_targets.
- Add 43 new tests for 100% coverage of check_test_isolation.py.
- Patch all transitive-subprocess violations across 18 test files.
- Update translations.json with new isolation check messages.
Generated with [Devin](https://devin.ai)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Auto-merge: If all CI checks pass, this PR will be merged automatically.
## Automated PR Review
- Architecture compliance: OK
- Best practices: OK
- Security: OK
- i18n: OK
- Resource management: OK
- Documentation: OK
- Tests: OK
- Commit conventions: OK
No issues found by automated checks.
---
**Auto-merge:** If all CI checks pass, this PR will be merged automatically.
kireto
approved these changes 2026-07-13 23:55:08 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
emil
kireto
DEVX-136: enhance check_test_isolation with transitive subprocess detectionto DEVX-136: Enhance check_test_isolation with transitive subprocess detectionAutomated PR Review
No issues found by automated checks.
Auto-merge: If all CI checks pass, this PR will be merged automatically.
Auto-approved: all CI checks passed (validate job).
- New devx.ci.fix_pr_title module: auto-fixes PR title to follow the {PREFIX}-N: <title> convention by fetching task ID from branch name and Vikunja task title. Supports --dry-run for safe preview. Falls back to stripping conventional-commit prefixes from current title when Vikunja task is not found. - New GiteaClient.update_pr() method for PATCH /pulls/{n} API calls - Added remediation hint to check_auto_merge_ready error output: when PR title format errors are detected, prints the exact fix_pr_title command to run - Tests: 8 new tests for fix_pr_title, 1 new test for update_pr This addresses the root cause of repeated validate CI failures where PR titles were created without the task ID prefix. The remediation hint in the error message now tells the user exactly how to fix it. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>Improve the static analysis call graph to detect transitive subprocess calls through helper functions. Key changes: - Stop adding KNOWN_SUBPROCESS_HELPERS to subprocess_calls directly; they are traversed via the call graph BFS instead, eliminating false positives when helpers are transitively patched (e.g. run_cmd patched → run_tests is safe). - Skip class methods in call graph registration to avoid false positives when classes are patched (e.g. @patch("TeaCLI") mocks all methods). - Fix _is_patched to use exact endswith matching instead of substring, preventing "run" from matching "run_cmd". - Add patch.object() and with patch() context manager support to _extract_patch_targets. - Add 43 new tests for 100% coverage of check_test_isolation.py. - Patch all transitive-subprocess violations across 18 test files. - Update translations.json with new isolation check messages. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>363e35a5d3to3428724a48Automated PR Review
No issues found by automated checks.
Auto-merge: If all CI checks pass, this PR will be merged automatically.
Auto-approved: all CI checks passed (validate job).