Public Access
Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
065a38b357 |
@@ -2,24 +2,6 @@
|
|||||||
|
|
||||||
All notable changes to this project will be documented in this file.
|
All notable changes to this project will be documented in this file.
|
||||||
|
|
||||||
## [0.53.1] - 2026-09-19
|
|
||||||
|
|
||||||
### Bug Fixes
|
|
||||||
|
|
||||||
- *(ci)* Handle list-shaped ref response in create_dependency_pr
|
|
||||||
|
|
||||||
## [0.53.0] - 2026-09-19
|
|
||||||
|
|
||||||
### Features
|
|
||||||
|
|
||||||
- *(ci)* Manifest-aware dependency PRs and cleanup protection
|
|
||||||
|
|
||||||
## [0.52.0] - 2026-09-19
|
|
||||||
|
|
||||||
### Features
|
|
||||||
|
|
||||||
- *(ci)* Verify producer container artifact before opening dependency PR
|
|
||||||
|
|
||||||
## [0.51.12] - 2026-09-19
|
## [0.51.12] - 2026-09-19
|
||||||
|
|
||||||
### Bug Fixes
|
### Bug Fixes
|
||||||
|
|||||||
@@ -16,12 +16,12 @@ quality badges.
|
|||||||
|
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/src/branch/master/LICENSE)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/src/branch/master/LICENSE)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/wiki)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/wiki)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/releases)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/releases)
|
||||||
[](https://www.python.org/downloads/)
|
[](https://www.python.org/downloads/)
|
||||||
|
|
||||||
## Why devx?
|
## Why devx?
|
||||||
|
|
||||||
@@ -87,7 +87,7 @@ extra index and list devx in your dependencies:
|
|||||||
```toml
|
```toml
|
||||||
[project]
|
[project]
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"devx>=0.53.1",
|
"devx>=0.51.12",
|
||||||
]
|
]
|
||||||
|
|
||||||
[tool.pip]
|
[tool.pip]
|
||||||
@@ -101,8 +101,8 @@ pip install -e .
|
|||||||
```
|
```
|
||||||
|
|
||||||
> **Note:** If your project requires a specific devx version, pin it in
|
> **Note:** If your project requires a specific devx version, pin it in
|
||||||
> `dependencies` (for example, `"devx==0.53.1"`) or use a version constraint
|
> `dependencies` (for example, `"devx==0.51.12"`) or use a version constraint
|
||||||
> (for example, `"devx>=0.53.1,<0.54"`).
|
> (for example, `"devx>=0.51.12,<0.52"`).
|
||||||
|
|
||||||
### Optional extras
|
### Optional extras
|
||||||
|
|
||||||
|
|||||||
+8
-8
@@ -12,12 +12,12 @@ project to be reusable across all oblachno-oss repositories.
|
|||||||
|
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/src/branch/master/LICENSE)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/src/branch/master/LICENSE)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/wiki)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/wiki)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/releases)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/releases)
|
||||||
[](https://www.python.org/downloads/)
|
[](https://www.python.org/downloads/)
|
||||||
|
|
||||||
## Overview
|
## Overview
|
||||||
|
|
||||||
@@ -74,14 +74,14 @@ Add devx to your `pyproject.toml` dependencies and configure the registry:
|
|||||||
```toml
|
```toml
|
||||||
[project]
|
[project]
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"devx>=0.53.1",
|
"devx>=0.51.12",
|
||||||
]
|
]
|
||||||
|
|
||||||
[tool.pip]
|
[tool.pip]
|
||||||
extra-index-url = "https://git.oblachno.oblachno.fyi/api/packages/oblachno-oss/pypi/simple"
|
extra-index-url = "https://git.oblachno.oblachno.fyi/api/packages/oblachno-oss/pypi/simple"
|
||||||
```
|
```
|
||||||
|
|
||||||
Pin a specific version if needed: `"devx==0.53.1"` or `"devx>=0.53.1,<0.54"`.
|
Pin a specific version if needed: `"devx==0.51.12"` or `"devx>=0.51.12,<0.52"`.
|
||||||
|
|
||||||
### Optional extras
|
### Optional extras
|
||||||
|
|
||||||
|
|||||||
@@ -1,35 +0,0 @@
|
|||||||
# DEVX-168: Fix create_dependency_pr master-ref parsing
|
|
||||||
|
|
||||||
## Problem
|
|
||||||
|
|
||||||
`devx.ci.create_dependency_pr` crashes with
|
|
||||||
`AttributeError: 'list' object has no attribute 'get'` when creating the
|
|
||||||
dependency branch. Gitea's `GET /repos/{o}/{r}/git/refs/heads/master`
|
|
||||||
returns a JSON **array** of matching refs, not a single object. Observed
|
|
||||||
in production when sso-bridge v0.4.1's post-merge dep-PR step ran.
|
|
||||||
|
|
||||||
## Approach
|
|
||||||
|
|
||||||
REQ-1: Normalize the ref response — if it is a list, select the entry
|
|
||||||
whose `ref` field equals `refs/heads/master` or fall back to the first
|
|
||||||
entry; proceed to extract `object.sha` as before. An empty or absent
|
|
||||||
SHA still fails closed.
|
|
||||||
|
|
||||||
## Test Plan
|
|
||||||
|
|
||||||
- Unit test: list-shaped response resolves SHA and creates the PR.
|
|
||||||
- Unit test: empty list fails with the master-SHA error message.
|
|
||||||
|
|
||||||
## Deploy Plan
|
|
||||||
|
|
||||||
devx releases as a version tag; sso-bridge/infra pin bumps pick it up via
|
|
||||||
their normal dep-PR flow.
|
|
||||||
|
|
||||||
## Rollback Plan
|
|
||||||
|
|
||||||
Revert the commit; dep-PR creation stays broken on Gitea (status quo).
|
|
||||||
|
|
||||||
## Acceptance Criteria
|
|
||||||
|
|
||||||
- [x] REQ-1: list-shaped ref response is handled; SHA extraction works;
|
|
||||||
empty list still errors. Covered by unit tests at 100% coverage.
|
|
||||||
@@ -48,12 +48,12 @@ Add devx to your `pyproject.toml`:
|
|||||||
```toml
|
```toml
|
||||||
[project]
|
[project]
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"devx>=0.53.1",
|
"devx>=0.51.12",
|
||||||
]
|
]
|
||||||
|
|
||||||
[project.optional-dependencies]
|
[project.optional-dependencies]
|
||||||
dev = [
|
dev = [
|
||||||
"devx>=0.53.1",
|
"devx>=0.51.12",
|
||||||
]
|
]
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
@@ -6,4 +6,4 @@ create_dependency_pr, auto_merge, release, publish), developer tooling
|
|||||||
molecule testing helpers for Ansible projects.
|
molecule testing helpers for Ansible projects.
|
||||||
"""
|
"""
|
||||||
|
|
||||||
__version__ = "0.53.1"
|
__version__ = "0.51.12"
|
||||||
|
|||||||
@@ -345,12 +345,6 @@ def cli(
|
|||||||
# Create branch via API
|
# Create branch via API
|
||||||
try:
|
try:
|
||||||
master_ref = client._request("GET", "/git/refs/heads/master").json()
|
master_ref = client._request("GET", "/git/refs/heads/master").json()
|
||||||
# Implements: REQ-1 — Gitea returns a list of matching refs
|
|
||||||
if isinstance(master_ref, list):
|
|
||||||
master_ref = next(
|
|
||||||
(r for r in master_ref if r.get("ref") == "refs/heads/master"),
|
|
||||||
master_ref[0] if master_ref else {},
|
|
||||||
)
|
|
||||||
master_sha = master_ref.get("object", {}).get("sha", "")
|
master_sha = master_ref.get("object", {}).get("sha", "")
|
||||||
if not master_sha:
|
if not master_sha:
|
||||||
raise click.ClickException("Could not get master SHA")
|
raise click.ClickException("Could not get master SHA")
|
||||||
|
|||||||
@@ -460,72 +460,3 @@ class TestCliManifestMode:
|
|||||||
assert result.exit_code == 0
|
assert result.exit_code == 0
|
||||||
args = mock_digest.call_args[0]
|
args = mock_digest.call_args[0]
|
||||||
assert args[1:4] == ("oblachno", "sso-bridge", "0.2.4")
|
assert args[1:4] == ("oblachno", "sso-bridge", "0.2.4")
|
||||||
|
|
||||||
|
|
||||||
class TestMasterRefParsing:
|
|
||||||
"""Gitea's /git/refs/heads/<branch> returns a list, not an object."""
|
|
||||||
|
|
||||||
def _invoke(self, client: MagicMock) -> object:
|
|
||||||
runner = CliRunner()
|
|
||||||
return runner.invoke(
|
|
||||||
cli,
|
|
||||||
[
|
|
||||||
"--package",
|
|
||||||
"sso_bridge",
|
|
||||||
"--new-version",
|
|
||||||
"0.9.1",
|
|
||||||
"--source-repo",
|
|
||||||
"oblachno/sso-bridge",
|
|
||||||
"--manifest",
|
|
||||||
"deploy/m.json",
|
|
||||||
],
|
|
||||||
)
|
|
||||||
|
|
||||||
@patch("devx.ci.create_dependency_pr.create_vikunja_task", return_value=None)
|
|
||||||
@patch("devx.ci.create_dependency_pr.update_manifest", return_value=True)
|
|
||||||
@patch("devx.ci.create_dependency_pr.read_manifest_version", return_value="0.9.0")
|
|
||||||
@patch("devx.ci.create_dependency_pr.find_existing_pr", return_value=None)
|
|
||||||
@patch("devx.ci.create_dependency_pr.GiteaClient")
|
|
||||||
@patch("devx.ci.create_dependency_pr.get_ci_token", return_value="tok")
|
|
||||||
def test_list_shaped_ref_response(
|
|
||||||
self,
|
|
||||||
_token: MagicMock,
|
|
||||||
mock_client_cls: MagicMock,
|
|
||||||
_find: MagicMock,
|
|
||||||
_read: MagicMock,
|
|
||||||
_update: MagicMock,
|
|
||||||
_task: MagicMock,
|
|
||||||
) -> None:
|
|
||||||
client = mock_client_cls.return_value
|
|
||||||
resp = MagicMock()
|
|
||||||
resp.json.return_value = [{"ref": "refs/heads/master", "object": {"sha": "abc123"}}]
|
|
||||||
client._request.return_value = resp
|
|
||||||
client.create_pr.return_value = {"number": 1}
|
|
||||||
result = self._invoke(client)
|
|
||||||
assert result.exit_code == 0
|
|
||||||
assert "Created PR" in result.output
|
|
||||||
post = client._request.call_args_list[-1]
|
|
||||||
assert post.kwargs["json"]["sha"] == "abc123"
|
|
||||||
|
|
||||||
@patch("devx.ci.create_dependency_pr.create_vikunja_task", return_value=None)
|
|
||||||
@patch("devx.ci.create_dependency_pr.update_manifest", return_value=True)
|
|
||||||
@patch("devx.ci.create_dependency_pr.read_manifest_version", return_value="0.9.0")
|
|
||||||
@patch("devx.ci.create_dependency_pr.find_existing_pr", return_value=None)
|
|
||||||
@patch("devx.ci.create_dependency_pr.GiteaClient")
|
|
||||||
@patch("devx.ci.create_dependency_pr.get_ci_token", return_value="tok")
|
|
||||||
def test_empty_ref_list_fails(
|
|
||||||
self,
|
|
||||||
_token: MagicMock,
|
|
||||||
mock_client_cls: MagicMock,
|
|
||||||
_find: MagicMock,
|
|
||||||
_read: MagicMock,
|
|
||||||
_update: MagicMock,
|
|
||||||
_task: MagicMock,
|
|
||||||
) -> None:
|
|
||||||
client = mock_client_cls.return_value
|
|
||||||
resp = MagicMock()
|
|
||||||
resp.json.return_value = []
|
|
||||||
client._request.return_value = resp
|
|
||||||
result = self._invoke(client)
|
|
||||||
assert result.exit_code != 0
|
|
||||||
assert "master SHA" in str(result.exception) or "master SHA" in result.output
|
|
||||||
|
|||||||
Reference in New Issue
Block a user