Public Access
Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
c8b5af3173 | ||
|
|
85f1bd9304 | ||
|
|
c6e895b230 | ||
|
|
d5a0f09b71 | ||
|
|
a68df7d785 | ||
|
|
d1e05db642 |
@@ -2,6 +2,18 @@
|
|||||||
|
|
||||||
All notable changes to this project will be documented in this file.
|
All notable changes to this project will be documented in this file.
|
||||||
|
|
||||||
|
## [0.53.2] - 2026-09-19
|
||||||
|
|
||||||
|
### Bug Fixes
|
||||||
|
|
||||||
|
- *(ci)* Create dep-PR branches via POST /branches
|
||||||
|
|
||||||
|
## [0.53.1] - 2026-09-19
|
||||||
|
|
||||||
|
### Bug Fixes
|
||||||
|
|
||||||
|
- *(ci)* Handle list-shaped ref response in create_dependency_pr
|
||||||
|
|
||||||
## [0.53.0] - 2026-09-19
|
## [0.53.0] - 2026-09-19
|
||||||
|
|
||||||
### Features
|
### Features
|
||||||
|
|||||||
@@ -16,12 +16,12 @@ quality badges.
|
|||||||
|
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/src/branch/master/LICENSE)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/src/branch/master/LICENSE)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/wiki)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/wiki)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/releases)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/releases)
|
||||||
[](https://www.python.org/downloads/)
|
[](https://www.python.org/downloads/)
|
||||||
|
|
||||||
## Why devx?
|
## Why devx?
|
||||||
|
|
||||||
@@ -87,7 +87,7 @@ extra index and list devx in your dependencies:
|
|||||||
```toml
|
```toml
|
||||||
[project]
|
[project]
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"devx>=0.53.0",
|
"devx>=0.53.2",
|
||||||
]
|
]
|
||||||
|
|
||||||
[tool.pip]
|
[tool.pip]
|
||||||
@@ -101,8 +101,8 @@ pip install -e .
|
|||||||
```
|
```
|
||||||
|
|
||||||
> **Note:** If your project requires a specific devx version, pin it in
|
> **Note:** If your project requires a specific devx version, pin it in
|
||||||
> `dependencies` (for example, `"devx==0.53.0"`) or use a version constraint
|
> `dependencies` (for example, `"devx==0.53.2"`) or use a version constraint
|
||||||
> (for example, `"devx>=0.53.0,<0.54"`).
|
> (for example, `"devx>=0.53.2,<0.54"`).
|
||||||
|
|
||||||
### Optional extras
|
### Optional extras
|
||||||
|
|
||||||
|
|||||||
+8
-8
@@ -12,12 +12,12 @@ project to be reusable across all oblachno-oss repositories.
|
|||||||
|
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/src/branch/master/LICENSE)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/src/branch/master/LICENSE)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/wiki)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/wiki)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/actions)
|
||||||
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/releases)
|
[](https://git.oblachno.oblachno.fyi/oblachno-oss/devx/releases)
|
||||||
[](https://www.python.org/downloads/)
|
[](https://www.python.org/downloads/)
|
||||||
|
|
||||||
## Overview
|
## Overview
|
||||||
|
|
||||||
@@ -74,14 +74,14 @@ Add devx to your `pyproject.toml` dependencies and configure the registry:
|
|||||||
```toml
|
```toml
|
||||||
[project]
|
[project]
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"devx>=0.53.0",
|
"devx>=0.53.2",
|
||||||
]
|
]
|
||||||
|
|
||||||
[tool.pip]
|
[tool.pip]
|
||||||
extra-index-url = "https://git.oblachno.oblachno.fyi/api/packages/oblachno-oss/pypi/simple"
|
extra-index-url = "https://git.oblachno.oblachno.fyi/api/packages/oblachno-oss/pypi/simple"
|
||||||
```
|
```
|
||||||
|
|
||||||
Pin a specific version if needed: `"devx==0.53.0"` or `"devx>=0.53.0,<0.54"`.
|
Pin a specific version if needed: `"devx==0.53.2"` or `"devx>=0.53.2,<0.54"`.
|
||||||
|
|
||||||
### Optional extras
|
### Optional extras
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,35 @@
|
|||||||
|
# DEVX-168: Fix create_dependency_pr master-ref parsing
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
`devx.ci.create_dependency_pr` crashes with
|
||||||
|
`AttributeError: 'list' object has no attribute 'get'` when creating the
|
||||||
|
dependency branch. Gitea's `GET /repos/{o}/{r}/git/refs/heads/master`
|
||||||
|
returns a JSON **array** of matching refs, not a single object. Observed
|
||||||
|
in production when sso-bridge v0.4.1's post-merge dep-PR step ran.
|
||||||
|
|
||||||
|
## Approach
|
||||||
|
|
||||||
|
REQ-1: Normalize the ref response — if it is a list, select the entry
|
||||||
|
whose `ref` field equals `refs/heads/master` or fall back to the first
|
||||||
|
entry; proceed to extract `object.sha` as before. An empty or absent
|
||||||
|
SHA still fails closed.
|
||||||
|
|
||||||
|
## Test Plan
|
||||||
|
|
||||||
|
- Unit test: list-shaped response resolves SHA and creates the PR.
|
||||||
|
- Unit test: empty list fails with the master-SHA error message.
|
||||||
|
|
||||||
|
## Deploy Plan
|
||||||
|
|
||||||
|
devx releases as a version tag; sso-bridge/infra pin bumps pick it up via
|
||||||
|
their normal dep-PR flow.
|
||||||
|
|
||||||
|
## Rollback Plan
|
||||||
|
|
||||||
|
Revert the commit; dep-PR creation stays broken on Gitea (status quo).
|
||||||
|
|
||||||
|
## Acceptance Criteria
|
||||||
|
|
||||||
|
- [x] REQ-1: list-shaped ref response is handled; SHA extraction works;
|
||||||
|
empty list still errors. Covered by unit tests at 100% coverage.
|
||||||
@@ -0,0 +1,33 @@
|
|||||||
|
# DEVX-169: create_dependency_pr uses branches API
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
After DEVX-168, dep-PR creation fails at `POST /git/refs` with
|
||||||
|
`HTTP 405 Method Not Allowed` — this Gitea version does not implement the
|
||||||
|
createRef endpoint. Observed creating the sso_bridge 0.4.1 infra
|
||||||
|
dependency PR.
|
||||||
|
|
||||||
|
## Approach
|
||||||
|
|
||||||
|
REQ-1: Create the dependency branch via `POST /branches` with
|
||||||
|
`new_branch_name`/`old_branch_name` (from master). An already-exists
|
||||||
|
error is tolerated; other API errors fail closed.
|
||||||
|
|
||||||
|
## Test Plan
|
||||||
|
|
||||||
|
- Branch creation calls `POST /branches` with the expected payload.
|
||||||
|
- 422 already-exists is tolerated and the PR is still created.
|
||||||
|
- Other API errors abort with a branch-creation failure.
|
||||||
|
|
||||||
|
## Deploy Plan
|
||||||
|
|
||||||
|
devx release tag; producers pick it up via pin bumps.
|
||||||
|
|
||||||
|
## Rollback Plan
|
||||||
|
|
||||||
|
Revert; dep-PR creation stays broken (status quo).
|
||||||
|
|
||||||
|
## Acceptance Criteria
|
||||||
|
|
||||||
|
- [x] REQ-1: branch creation uses the branches API; already-exists
|
||||||
|
tolerated; failures surface. Covered by unit tests at 100% coverage.
|
||||||
@@ -48,12 +48,12 @@ Add devx to your `pyproject.toml`:
|
|||||||
```toml
|
```toml
|
||||||
[project]
|
[project]
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"devx>=0.53.0",
|
"devx>=0.53.2",
|
||||||
]
|
]
|
||||||
|
|
||||||
[project.optional-dependencies]
|
[project.optional-dependencies]
|
||||||
dev = [
|
dev = [
|
||||||
"devx>=0.53.0",
|
"devx>=0.53.2",
|
||||||
]
|
]
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
@@ -6,4 +6,4 @@ create_dependency_pr, auto_merge, release, publish), developer tooling
|
|||||||
molecule testing helpers for Ansible projects.
|
molecule testing helpers for Ansible projects.
|
||||||
"""
|
"""
|
||||||
|
|
||||||
__version__ = "0.53.0"
|
__version__ = "0.53.2"
|
||||||
|
|||||||
@@ -344,11 +344,13 @@ def cli(
|
|||||||
|
|
||||||
# Create branch via API
|
# Create branch via API
|
||||||
try:
|
try:
|
||||||
master_ref = client._request("GET", "/git/refs/heads/master").json()
|
# Implements: REQ-1 — Gitea lacks POST /git/refs; create the branch
|
||||||
master_sha = master_ref.get("object", {}).get("sha", "")
|
# from master via the branches API.
|
||||||
if not master_sha:
|
client._request(
|
||||||
raise click.ClickException("Could not get master SHA")
|
"POST",
|
||||||
client._request("POST", "/git/refs", json={"ref": f"refs/heads/{branch_name}", "sha": master_sha})
|
"/branches",
|
||||||
|
json={"new_branch_name": branch_name, "old_branch_name": base_branch},
|
||||||
|
)
|
||||||
except APIError as e:
|
except APIError as e:
|
||||||
if "already exists" in str(e).lower():
|
if "already exists" in str(e).lower():
|
||||||
click.echo(f"[dep-pr] Branch {branch_name} already exists")
|
click.echo(f"[dep-pr] Branch {branch_name} already exists")
|
||||||
|
|||||||
@@ -460,3 +460,100 @@ class TestCliManifestMode:
|
|||||||
assert result.exit_code == 0
|
assert result.exit_code == 0
|
||||||
args = mock_digest.call_args[0]
|
args = mock_digest.call_args[0]
|
||||||
assert args[1:4] == ("oblachno", "sso-bridge", "0.2.4")
|
assert args[1:4] == ("oblachno", "sso-bridge", "0.2.4")
|
||||||
|
|
||||||
|
|
||||||
|
class TestBranchCreation:
|
||||||
|
"""Branch creation uses the branches API (Gitea lacks POST /git/refs)."""
|
||||||
|
|
||||||
|
def _invoke(self) -> object:
|
||||||
|
runner = CliRunner()
|
||||||
|
return runner.invoke(
|
||||||
|
cli,
|
||||||
|
[
|
||||||
|
"--package",
|
||||||
|
"sso_bridge",
|
||||||
|
"--new-version",
|
||||||
|
"0.9.1",
|
||||||
|
"--source-repo",
|
||||||
|
"oblachno/sso-bridge",
|
||||||
|
"--manifest",
|
||||||
|
"deploy/m.json",
|
||||||
|
],
|
||||||
|
)
|
||||||
|
|
||||||
|
def _client(self, mock_client_cls: MagicMock) -> MagicMock:
|
||||||
|
client = mock_client_cls.return_value
|
||||||
|
client.create_pr.return_value = {"number": 1}
|
||||||
|
return client
|
||||||
|
|
||||||
|
@patch("devx.ci.create_dependency_pr.create_vikunja_task", return_value=None)
|
||||||
|
@patch("devx.ci.create_dependency_pr.update_manifest", return_value=True)
|
||||||
|
@patch("devx.ci.create_dependency_pr.read_manifest_version", return_value="0.9.0")
|
||||||
|
@patch("devx.ci.create_dependency_pr.find_existing_pr", return_value=None)
|
||||||
|
@patch("devx.ci.create_dependency_pr.GiteaClient")
|
||||||
|
@patch("devx.ci.create_dependency_pr.get_ci_token", return_value="tok")
|
||||||
|
def test_creates_branch_via_branches_api(
|
||||||
|
self,
|
||||||
|
_token: MagicMock,
|
||||||
|
mock_client_cls: MagicMock,
|
||||||
|
_find: MagicMock,
|
||||||
|
_read: MagicMock,
|
||||||
|
_update: MagicMock,
|
||||||
|
_task: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
client = self._client(mock_client_cls)
|
||||||
|
result = self._invoke()
|
||||||
|
assert result.exit_code == 0
|
||||||
|
assert "Created PR" in result.output
|
||||||
|
post = client._request.call_args
|
||||||
|
assert post.args[:2] == ("POST", "/branches")
|
||||||
|
assert post.kwargs["json"] == {
|
||||||
|
"new_branch_name": "deps/sso_bridge-0.9.1",
|
||||||
|
"old_branch_name": "master",
|
||||||
|
}
|
||||||
|
|
||||||
|
@patch("devx.ci.create_dependency_pr.create_vikunja_task", return_value=None)
|
||||||
|
@patch("devx.ci.create_dependency_pr.update_manifest", return_value=True)
|
||||||
|
@patch("devx.ci.create_dependency_pr.read_manifest_version", return_value="0.9.0")
|
||||||
|
@patch("devx.ci.create_dependency_pr.find_existing_pr", return_value=None)
|
||||||
|
@patch("devx.ci.create_dependency_pr.GiteaClient")
|
||||||
|
@patch("devx.ci.create_dependency_pr.get_ci_token", return_value="tok")
|
||||||
|
def test_existing_branch_tolerated(
|
||||||
|
self,
|
||||||
|
_token: MagicMock,
|
||||||
|
mock_client_cls: MagicMock,
|
||||||
|
_find: MagicMock,
|
||||||
|
_read: MagicMock,
|
||||||
|
_update: MagicMock,
|
||||||
|
_task: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
from devx.exceptions import APIError
|
||||||
|
|
||||||
|
client = self._client(mock_client_cls)
|
||||||
|
client._request.side_effect = APIError(422, "branch already exists")
|
||||||
|
result = self._invoke()
|
||||||
|
assert result.exit_code == 0
|
||||||
|
assert "already exists" in result.output.lower()
|
||||||
|
|
||||||
|
@patch("devx.ci.create_dependency_pr.create_vikunja_task", return_value=None)
|
||||||
|
@patch("devx.ci.create_dependency_pr.update_manifest", return_value=True)
|
||||||
|
@patch("devx.ci.create_dependency_pr.read_manifest_version", return_value="0.9.0")
|
||||||
|
@patch("devx.ci.create_dependency_pr.find_existing_pr", return_value=None)
|
||||||
|
@patch("devx.ci.create_dependency_pr.GiteaClient")
|
||||||
|
@patch("devx.ci.create_dependency_pr.get_ci_token", return_value="tok")
|
||||||
|
def test_branch_api_error_fails(
|
||||||
|
self,
|
||||||
|
_token: MagicMock,
|
||||||
|
mock_client_cls: MagicMock,
|
||||||
|
_find: MagicMock,
|
||||||
|
_read: MagicMock,
|
||||||
|
_update: MagicMock,
|
||||||
|
_task: MagicMock,
|
||||||
|
) -> None:
|
||||||
|
from devx.exceptions import APIError
|
||||||
|
|
||||||
|
client = self._client(mock_client_cls)
|
||||||
|
client._request.side_effect = APIError(500, "boom")
|
||||||
|
result = self._invoke()
|
||||||
|
assert result.exit_code != 0
|
||||||
|
assert "Failed to create branch" in result.output
|
||||||
|
|||||||
Reference in New Issue
Block a user