DEVX-171: feat(ci): dep PRs carry target-repo task ID and generated spec

2026-09-19 19:30:05 +00:00
parent 32730d551d
commit f9e43ce268
4 changed files with 136 additions and 15 deletions
@@ -189,6 +189,16 @@ class TestCreateVikunjaTask:
            result = create_vikunja_task("Test", "desc")
            assert result == "OBL-INFRA-999"

+    def test_explicit_project_id_used(self) -> None:
+        with (
+            patch("devx.ci.create_dependency_pr.get_vikunja_token", return_value="fake-token"),
+            patch("devx.api_clients.VikunjaClient") as mock_client_cls,
+        ):
+            mock_client = mock_client_cls.return_value
+            mock_client.create_task.return_value = {"identifier": "OBL-INFRA-1"}
+            create_vikunja_task("Test", "desc", project_id=3)
+            assert mock_client.create_task.call_args.args[0] == 3
+

 class TestResolveContainerDigest:
    """REQ-1: pre-PR artifact verification via the packages API."""
@@ -581,3 +591,33 @@ class TestBranchCreation:
        calls = [c.args[0] for c in subprocess.run.call_args_list]
        assert ["git", "fetch", "origin", "deps/sso_bridge-0.9.1:refs/remotes/origin/deps/sso_bridge-0.9.1"] in calls
        assert ["git", "checkout", "-B", "deps/sso_bridge-0.9.1", "origin/deps/sso_bridge-0.9.1"] in calls
+
+    @patch("devx.ci.create_dependency_pr.create_vikunja_task", return_value="OBL-INFRA-581")
+    @patch("devx.ci.create_dependency_pr.update_manifest", return_value=True)
+    @patch("devx.ci.create_dependency_pr.read_manifest_version", return_value="0.9.0")
+    @patch("devx.ci.create_dependency_pr.find_existing_pr", return_value=None)
+    @patch("devx.ci.create_dependency_pr.GiteaClient")
+    @patch("devx.ci.create_dependency_pr.get_ci_token", return_value="tok")
+    def test_task_id_in_branch_and_spec_committed(
+        self,
+        _token: MagicMock,
+        mock_client_cls: MagicMock,
+        _find: MagicMock,
+        _read: MagicMock,
+        _update: MagicMock,
+        mock_task: MagicMock,
+    ) -> None:
+        import subprocess
+
+        client = self._client(mock_client_cls)
+        result = self._invoke()
+        assert result.exit_code == 0
+        # Branch embeds the target-repo task ID
+        post = client._request.call_args
+        assert post.kwargs["json"]["new_branch_name"] == "deps/OBL-INFRA-581-sso_bridge-0.9.1"
+        # Spec file added alongside the manifest change
+        add = next(c for c in subprocess.run.call_args_list if c.args[0][:2] == ["git", "add"])
+        assert "docs/specs/OBL-INFRA-581.md" in add.args[0]
+        # PR title carries the task ID
+        assert client.create_pr.call_args.kwargs["title"] == "OBL-INFRA-581: Bump sso_bridge to 0.9.1"
+        mock_task.assert_called_once()