DEVX-168: fix(ci): handle list-shaped ref response in create_dependency_pr

2026-09-19 19:06:07 +00:00
parent d1e05db642
commit a68df7d785
3 changed files with 110 additions and 0 deletions
@@ -460,3 +460,72 @@ class TestCliManifestMode:
        assert result.exit_code == 0
        args = mock_digest.call_args[0]
        assert args[1:4] == ("oblachno", "sso-bridge", "0.2.4")
+
+
+class TestMasterRefParsing:
+    """Gitea's /git/refs/heads/<branch> returns a list, not an object."""
+
+    def _invoke(self, client: MagicMock) -> object:
+        runner = CliRunner()
+        return runner.invoke(
+            cli,
+            [
+                "--package",
+                "sso_bridge",
+                "--new-version",
+                "0.9.1",
+                "--source-repo",
+                "oblachno/sso-bridge",
+                "--manifest",
+                "deploy/m.json",
+            ],
+        )
+
+    @patch("devx.ci.create_dependency_pr.create_vikunja_task", return_value=None)
+    @patch("devx.ci.create_dependency_pr.update_manifest", return_value=True)
+    @patch("devx.ci.create_dependency_pr.read_manifest_version", return_value="0.9.0")
+    @patch("devx.ci.create_dependency_pr.find_existing_pr", return_value=None)
+    @patch("devx.ci.create_dependency_pr.GiteaClient")
+    @patch("devx.ci.create_dependency_pr.get_ci_token", return_value="tok")
+    def test_list_shaped_ref_response(
+        self,
+        _token: MagicMock,
+        mock_client_cls: MagicMock,
+        _find: MagicMock,
+        _read: MagicMock,
+        _update: MagicMock,
+        _task: MagicMock,
+    ) -> None:
+        client = mock_client_cls.return_value
+        resp = MagicMock()
+        resp.json.return_value = [{"ref": "refs/heads/master", "object": {"sha": "abc123"}}]
+        client._request.return_value = resp
+        client.create_pr.return_value = {"number": 1}
+        result = self._invoke(client)
+        assert result.exit_code == 0
+        assert "Created PR" in result.output
+        post = client._request.call_args_list[-1]
+        assert post.kwargs["json"]["sha"] == "abc123"
+
+    @patch("devx.ci.create_dependency_pr.create_vikunja_task", return_value=None)
+    @patch("devx.ci.create_dependency_pr.update_manifest", return_value=True)
+    @patch("devx.ci.create_dependency_pr.read_manifest_version", return_value="0.9.0")
+    @patch("devx.ci.create_dependency_pr.find_existing_pr", return_value=None)
+    @patch("devx.ci.create_dependency_pr.GiteaClient")
+    @patch("devx.ci.create_dependency_pr.get_ci_token", return_value="tok")
+    def test_empty_ref_list_fails(
+        self,
+        _token: MagicMock,
+        mock_client_cls: MagicMock,
+        _find: MagicMock,
+        _read: MagicMock,
+        _update: MagicMock,
+        _task: MagicMock,
+    ) -> None:
+        client = mock_client_cls.return_value
+        resp = MagicMock()
+        resp.json.return_value = []
+        client._request.return_value = resp
+        result = self._invoke(client)
+        assert result.exit_code != 0
+        assert "master SHA" in str(result.exception) or "master SHA" in result.output