DEVX-14: fix: retry wiki integrity check on transient API timeout

tests/unit/test_sync_wiki.py

@@ -21,6 +21,7 @@ from devx.ci.sync_wiki import (
     verify_wiki_integrity,
     verify_wiki_page,
 )
+from devx.exceptions import APIError
 
 
 class TestEncodeContent:
@@ -97,13 +98,11 @@ class TestReadDocContent:
 
 
 class TestListWikiPages:
-    def test_returns_empty_on_api_error(self) -> None:
-        from devx.exceptions import APIError
-
+    def test_raises_on_api_error(self) -> None:
         client = MagicMock()
         client._request.side_effect = APIError(404, "not found")
-        result = list_wiki_pages(client)
-        assert result == {}
+        with pytest.raises(APIError):
+            list_wiki_pages(client)
 
     def test_returns_page_dict(self) -> None:
         client = MagicMock()
@@ -284,6 +283,43 @@ class TestVerifyWikiIntegrity:
         failures = verify_wiki_integrity(client, mapping, synced)
         assert len(failures) >= 3  # count mismatch, missing FAQ, stale Stale, empty Home
 
+    def test_transient_api_failure_returns_empty(self) -> None:
+        """When the wiki API is unavailable after retries, integrity check
+        should return no failures (sync already succeeded)."""
+        client = MagicMock()
+
+        # _list_wiki_pages_with_retry raises APIError (retries exhausted)
+        with patch("devx.ci.sync_wiki._list_wiki_pages_with_retry", side_effect=APIError(0, "timeout")):
+            mapping = {"index.md": "Home", "faq.md": "FAQ"}
+            synced = {"Home": "# Home", "FAQ": "# FAQ"}
+            failures = verify_wiki_integrity(client, mapping, synced)
+        assert failures == []
+
+    def test_transient_api_failure_recovers_on_retry(self) -> None:
+        """When the wiki API recovers after a retry, integrity check proceeds normally."""
+        client = MagicMock()
+        pages = {"Home": "Home", "FAQ": "FAQ"}
+        contents = {"Home": "# Home", "FAQ": "# FAQ"}
+
+        def mock_request(method, path, **kwargs):
+            resp = MagicMock()
+            if path == "/wiki/pages":
+                page_list = [{"title": t, "sub_url": s} for t, s in pages.items()]
+                resp.json.return_value = page_list
+            elif path.startswith("/wiki/page/"):
+                sub_url = path.replace("/wiki/page/", "")
+                content = contents.get(sub_url, "")
+                encoded = base64.b64encode(content.encode()).decode("ascii") if content else ""
+                resp.json.return_value = {"content_base64": encoded}
+            return resp
+
+        client._request.side_effect = mock_request
+
+        mapping = {"index.md": "Home", "faq.md": "FAQ"}
+        synced = {"Home": "# Home", "FAQ": "# FAQ"}
+        failures = verify_wiki_integrity(client, mapping, synced)
+        assert failures == []
+
 
 class TestMain:
     @patch.dict("os.environ", {"CI_GITEA_TOKEN": "tok"})
@@ -498,3 +534,41 @@ class TestMain:
                         result = runner.invoke(main, ["--dry-run", "--strict", "--repo", "owner/repo"])
         assert result.exit_code == 0
         assert "Integrity check" not in result.output
+
+    @patch.dict("os.environ", {"CI_GITEA_TOKEN": "tok"}, clear=True)
+    @patch("devx.ci.sync_wiki.GiteaClient")
+    def test_initial_list_api_error_treated_as_empty(self, mock_client_cls: MagicMock) -> None:
+        """When the initial page list fails, sync proceeds treating wiki as empty."""
+        mock_client = MagicMock()
+        mock_client_cls.return_value = mock_client
+        with patch("devx.ci.sync_wiki.MAPPING_FILE") as mock_mapping:
+            mock_mapping.exists.return_value = True
+            with patch("devx.ci.sync_wiki.load_mapping", return_value={"index.md": "Home"}):
+                with patch("devx.ci.sync_wiki.read_doc_content", return_value="# Home"):
+                    with patch("devx.ci.sync_wiki.list_wiki_pages", side_effect=APIError(0, "timeout")):
+                        with patch("devx.ci.sync_wiki.sync_page", return_value="created"):
+                            runner = CliRunner()
+                            result = runner.invoke(main, ["--repo", "owner/repo"])
+        assert result.exit_code == 0
+        assert "Created: Home" in result.output
+
+    @patch.dict("os.environ", {"CI_GITEA_TOKEN": "tok"}, clear=True)
+    @patch("devx.ci.sync_wiki.GiteaClient")
+    def test_verify_skips_when_refetch_fails(self, mock_client_cls: MagicMock) -> None:
+        """When --verify re-fetch fails after retries, verification is skipped gracefully."""
+        mock_client = MagicMock()
+        mock_client_cls.return_value = mock_client
+        with patch("devx.ci.sync_wiki.MAPPING_FILE") as mock_mapping:
+            mock_mapping.exists.return_value = True
+            with patch("devx.ci.sync_wiki.load_mapping", return_value={"index.md": "Home"}):
+                with patch("devx.ci.sync_wiki.read_doc_content", return_value="# Home"):
+                    with patch("devx.ci.sync_wiki.list_wiki_pages", return_value={"Home": "Home"}):
+                        with patch("devx.ci.sync_wiki.sync_page", return_value="updated"):
+                            with patch(
+                                "devx.ci.sync_wiki._list_wiki_pages_with_retry",
+                                side_effect=APIError(0, "timeout"),
+                            ):
+                                runner = CliRunner()
+                                result = runner.invoke(main, ["--repo", "owner/repo", "--verify"])
+        assert result.exit_code == 0
+        assert "Skipping content verification" in result.output