DEVX-7: fix: make all warnings into errors across devx tools

tests/unit/test_sync_wiki.py

@@ -5,6 +5,7 @@ import json
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
+import click
 import pytest
 from click.testing import CliRunner
 
@@ -63,6 +64,22 @@ class TestLoadMapping:
             with pytest.raises(FileNotFoundError):
                 load_mapping()
 
+    def test_non_dict_mapping_raises(self, tmp_path: Path) -> None:
+        """Non-dict mapping.json should raise."""
+        mapping_file = tmp_path / "mapping.json"
+        mapping_file.write_text('["not", "a", "dict"]')
+        with patch("devx.ci.sync_wiki.MAPPING_FILE", mapping_file):
+            with pytest.raises(click.ClickException, match="must be a dict"):
+                load_mapping()
+
+    def test_non_string_values_raise(self, tmp_path: Path) -> None:
+        """Non-string values in mapping.json should raise."""
+        mapping_file = tmp_path / "mapping.json"
+        mapping_file.write_text('{"file.md": 123}')
+        with patch("devx.ci.sync_wiki.MAPPING_FILE", mapping_file):
+            with pytest.raises(click.ClickException, match="must be strings"):
+                load_mapping()
+
 
 class TestReadDocContent:
     def test_reads_file(self, tmp_path: Path) -> None:
@@ -332,8 +349,8 @@ class TestMain:
 
     @patch.dict("os.environ", {"REPO_TOKEN": "tok"}, clear=True)
     @patch("devx.ci.sync_wiki.GiteaClient")
-    def test_file_not_found_warning(self, mock_client_cls: MagicMock) -> None:
-        """Test that missing doc files are skipped with a warning."""
+    def test_file_not_found_fails(self, mock_client_cls: MagicMock) -> None:
+        """Test that missing doc files cause an error, not a warning."""
         with patch("devx.ci.sync_wiki.MAPPING_FILE") as mock_mapping:
             mock_mapping.exists.return_value = True
             with patch("devx.ci.sync_wiki.load_mapping", return_value={"missing.md": "Missing"}):
@@ -341,14 +358,13 @@ class TestMain:
                     with patch("devx.ci.sync_wiki.list_wiki_pages", return_value={}):
                         runner = CliRunner()
                         result = runner.invoke(main, ["--dry-run", "--repo", "owner/repo"])
-        assert result.exit_code == 0
+        assert result.exit_code != 0
         assert "not found" in result.output
-        assert "Skipped: 1" in result.output
 
     @patch.dict("os.environ", {"REPO_TOKEN": "tok"}, clear=True)
     @patch("devx.ci.sync_wiki.GiteaClient")
-    def test_empty_doc_file_skipped(self, mock_client_cls: MagicMock) -> None:
-        """Test that empty doc files are skipped with a warning."""
+    def test_empty_doc_file_fails(self, mock_client_cls: MagicMock) -> None:
+        """Test that empty doc files cause an error, not a warning."""
         with patch("devx.ci.sync_wiki.MAPPING_FILE") as mock_mapping:
             mock_mapping.exists.return_value = True
             with patch("devx.ci.sync_wiki.load_mapping", return_value={"empty.md": "Empty-Page"}):
@@ -356,9 +372,8 @@ class TestMain:
                     with patch("devx.ci.sync_wiki.list_wiki_pages", return_value={}):
                         runner = CliRunner()
                         result = runner.invoke(main, ["--dry-run", "--repo", "owner/repo"])
-        assert result.exit_code == 0
+        assert result.exit_code != 0
         assert "empty" in result.output.lower()
-        assert "Skipped: 1" in result.output
 
     @patch.dict("os.environ", {"REPO_TOKEN": "tok"}, clear=True)
     @patch("devx.ci.sync_wiki.GiteaClient")