DEVX-91: feat: add manual review support to pr_review (--event, --body, --checklist-confirmed)

tests/unit/test_auto_merge.py

@@ -195,6 +195,29 @@ class TestExtractConventionalMsg:
         ]
         assert extract_conventional_msg(commits) == "feat: add feature"
 
+    def test_prefers_feat_over_refactor(self) -> None:
+        """When both feat and refactor commits exist, feat wins."""
+        commits = [
+            {"commit": {"message": "refactor: add find_task_by_identifier"}},
+            {"commit": {"message": "fix: remove hardcoded fallbacks"}},
+            {"commit": {"message": "feat: add manual review support"}},
+        ]
+        assert extract_conventional_msg(commits) == "feat: add manual review support"
+
+    def test_prefers_fix_over_docs(self) -> None:
+        commits = [
+            {"commit": {"message": "docs: update README"}},
+            {"commit": {"message": "fix: resolve bug"}},
+        ]
+        assert extract_conventional_msg(commits) == "fix: resolve bug"
+
+    def test_scope_in_prefix(self) -> None:
+        commits = [
+            {"commit": {"message": "refactor(ci): cleanup code"}},
+            {"commit": {"message": "feat(api): add endpoint"}},
+        ]
+        assert extract_conventional_msg(commits) == "feat(api): add endpoint"
+
 
 # -- run_cmd --
 

tests/unit/test_pr_review.py

@@ -733,6 +733,182 @@ class TestMain:
         assert "CI_GITEA_TOKEN" in result.output
 
 
+class TestManualReview:
+    @patch("devx.ci.pr_review.GiteaClient")
+    def test_approve_success(self, mock_client_class: MagicMock) -> None:
+        mock_client_class.return_value.create_review.return_value = {"id": 200}
+        runner = CliRunner()
+        result = runner.invoke(
+            main,
+            [
+                "42",
+                "oblachno-oss/devx",
+                "--event",
+                "APPROVE",
+                "--body",
+                "All 13 REVIEW_CHECKLIST.md categories verified. Architecture: clean. Security: no issues.",
+                "--checklist-confirmed",
+                "--checklist-categories",
+                "1,2,3,4,5,6,7,8,9,10,11,12,13",
+            ],
+            env={"CI_GITEA_TOKEN": "fake"},
+        )
+        assert result.exit_code == 0
+        assert "Review #200" in result.output
+
+    @patch("devx.ci.pr_review.GiteaClient")
+    def test_approve_without_checklist_confirmed_fails(self, mock_client_class: MagicMock) -> None:
+        runner = CliRunner()
+        result = runner.invoke(
+            main,
+            [
+                "42",
+                "oblachno-oss/devx",
+                "--event",
+                "APPROVE",
+                "--body",
+                "x" * 60,
+                "--checklist-categories",
+                "1,2,3,4,5,6,7,8",
+            ],
+            env={"CI_GITEA_TOKEN": "fake"},
+        )
+        assert result.exit_code != 0
+        assert "checklist-confirmed" in result.output
+
+    @patch("devx.ci.pr_review.GiteaClient")
+    def test_approve_with_too_few_categories_fails(self, mock_client_class: MagicMock) -> None:
+        runner = CliRunner()
+        result = runner.invoke(
+            main,
+            [
+                "42",
+                "oblachno-oss/devx",
+                "--event",
+                "APPROVE",
+                "--body",
+                "x" * 60,
+                "--checklist-confirmed",
+                "--checklist-categories",
+                "1,2,3",
+            ],
+            env={"CI_GITEA_TOKEN": "fake"},
+        )
+        assert result.exit_code != 0
+        assert "at least 8" in result.output
+
+    @patch("devx.ci.pr_review.GiteaClient")
+    def test_approve_with_short_body_fails(self, mock_client_class: MagicMock) -> None:
+        runner = CliRunner()
+        result = runner.invoke(
+            main,
+            [
+                "42",
+                "oblachno-oss/devx",
+                "--event",
+                "APPROVE",
+                "--body",
+                "LGTM",
+                "--checklist-confirmed",
+                "--checklist-categories",
+                "1,2,3,4,5,6,7,8",
+            ],
+            env={"CI_GITEA_TOKEN": "fake"},
+        )
+        assert result.exit_code != 0
+        assert "50 characters" in result.output
+
+    @patch("devx.ci.pr_review.GiteaClient")
+    def test_approve_with_invalid_category_fails(self, mock_client_class: MagicMock) -> None:
+        runner = CliRunner()
+        result = runner.invoke(
+            main,
+            [
+                "42",
+                "oblachno-oss/devx",
+                "--event",
+                "APPROVE",
+                "--body",
+                "x" * 60,
+                "--checklist-confirmed",
+                "--checklist-categories",
+                "1,2,abc,4",
+            ],
+            env={"CI_GITEA_TOKEN": "fake"},
+        )
+        assert result.exit_code != 0
+        assert "Invalid" in result.output
+
+    @patch("devx.ci.pr_review.GiteaClient")
+    def test_request_changes_success(self, mock_client_class: MagicMock) -> None:
+        mock_client_class.return_value.create_review.return_value = {"id": 201}
+        runner = CliRunner()
+        result = runner.invoke(
+            main,
+            [
+                "42",
+                "oblachno-oss/devx",
+                "--event",
+                "REQUEST_CHANGES",
+                "--body",
+                "Please fix the architecture issues in the CLI module before merging.",
+            ],
+            env={"CI_GITEA_TOKEN": "fake"},
+        )
+        assert result.exit_code == 0
+        assert "Review #201" in result.output
+
+    @patch("devx.ci.pr_review.GiteaClient")
+    def test_manual_review_dry_run(self, mock_client_class: MagicMock) -> None:
+        runner = CliRunner()
+        result = runner.invoke(
+            main,
+            ["42", "oblachno-oss/devx", "--event", "COMMENT", "--body", "x" * 60, "--dry-run"],
+            env={"CI_GITEA_TOKEN": "fake"},
+        )
+        assert result.exit_code == 0
+        assert "[dry-run]" in result.output
+        mock_client_class.return_value.create_review.assert_not_called()
+
+    @patch("devx.ci.pr_review.GiteaClient")
+    def test_manual_review_self_approval_fallback(self, mock_client_class: MagicMock) -> None:
+        client = mock_client_class.return_value
+        client.create_review.side_effect = [
+            APIError(422, "approve your own pull is not allowed"),
+            {"id": 202},
+        ]
+        runner = CliRunner()
+        result = runner.invoke(
+            main,
+            [
+                "42",
+                "oblachno-oss/devx",
+                "--event",
+                "APPROVE",
+                "--body",
+                "x" * 60,
+                "--checklist-confirmed",
+                "--checklist-categories",
+                "1,2,3,4,5,6,7,8",
+            ],
+            env={"CI_GITEA_TOKEN": "fake"},
+        )
+        assert result.exit_code == 0
+        assert "Review #202" in result.output
+
+    @patch("devx.ci.pr_review.GiteaClient")
+    def test_manual_review_other_error_re_raises(self, mock_client_class: MagicMock) -> None:
+        client = mock_client_class.return_value
+        client.create_review.side_effect = APIError(500, "Internal server error")
+        runner = CliRunner()
+        result = runner.invoke(
+            main,
+            ["42", "oblachno-oss/devx", "--event", "COMMENT", "--body", "x" * 60],
+            env={"CI_GITEA_TOKEN": "fake"},
+        )
+        assert result.exit_code != 0
+
+
 def test_main_module_block() -> None:
     import devx.ci.pr_review as pr