DEVX-88: fix: correct clean_images delete URL and add retry with error handling

src/devx/tools/clean_images.py

@@ -34,6 +34,7 @@ Authentication uses ``CI_GITEA_TOKEN`` environment variable.
 from __future__ import annotations
 
 import os
+import time
 from typing import Any
 
 import click
@@ -85,15 +86,37 @@ def delete_package_version(
     token: str,
     *,
     timeout: int = 30,
+    package_type: str = "container",
+    max_retries: int = 3,
 ) -> bool:
     """Delete a specific version of a container package.
 
+    Uses the Gitea API endpoint ``DELETE /packages/{owner}/{type}/{name}/{version}``.
+    Retries on transient failures (5xx, timeouts) up to ``max_retries`` times.
+
     Returns True on success, False on failure.
     """
-    url = f"{api_url}/packages/{owner}/{name}/{version}"
+    url = f"{api_url}/packages/{owner}/{package_type}/{name}/{version}"
     headers = {"Authorization": f"token {token}"}
-    resp = requests.delete(url, headers=headers, timeout=timeout)
-    return resp.status_code in (204, 200)
+    for attempt in range(max_retries):
+        try:
+            resp = requests.delete(url, headers=headers, timeout=timeout)
+        except requests.RequestException:
+            if attempt < max_retries - 1:
+                time.sleep(2**attempt)
+                continue
+            return False
+        if resp.status_code in (204, 200):
+            return True
+        # 404 means already deleted — treat as success
+        if resp.status_code == 404:
+            return True
+        # 5xx is transient — retry
+        if 500 <= resp.status_code < 600 and attempt < max_retries - 1:
+            time.sleep(2**attempt)
+            continue
+        return False
+    return False
 
 
 def sort_versions_by_date(
@@ -171,6 +194,7 @@ def main(
 
     total_deleted = 0
     total_kept = 0
+    total_failed = 0
     for name in names:
         click.echo(f"\n{'=' * 60}")
         click.echo(f"Package: {owner}/{name}")
@@ -182,6 +206,7 @@ def main(
                 _("Failed to list versions for {name}: {error}", name=name, error=exc),
                 err=True,
             )
+            total_failed += 1
             continue
 
         if not versions:
@@ -203,6 +228,7 @@ def main(
             continue
 
         deleted_count = 0
+        failed_count = 0
         for v in to_delete:
             version = str(v.get("version", ""))
             if delete_package_version(base_url, owner, name, version, token):
@@ -210,11 +236,15 @@ def main(
                 deleted_count += 1
             else:
                 click.echo(f"  FAILED to delete: {version}", err=True)
+                failed_count += 1
 
         total_deleted += deleted_count
         total_kept += kept_count
+        total_failed += failed_count
 
-    click.echo(f"\nDone. Deleted {total_deleted}, kept {total_kept}.")
+    click.echo(f"\nDone. Deleted {total_deleted}, kept {total_kept}, failed {total_failed}.")
+    if total_failed > 0:
+        raise click.ClickException(_("Failed to delete {count} image version(s)", count=total_failed))
 
 
 if __name__ == "__main__":  # pragma: no cover

src/devx/translations.json

@@ -1391,6 +1391,14 @@
     "ru": "CI_GITEA_TOKEN environment variable required",
     "zh": "CI_GITEA_TOKEN environment variable required"
   },
+  "Failed to delete {count} image version(s)": {
+    "bg": "Failed to delete {count} image version(s)",
+    "de": "Failed to delete {count} image version(s)",
+    "en": "Failed to delete {count} image version(s)",
+    "pl": "Failed to delete {count} image version(s)",
+    "ru": "Failed to delete {count} image version(s)",
+    "zh": "Failed to delete {count} image version(s)"
+  },
   "CI_GITEA_TOKEN is not set. Required to create a PR.": {
     "bg": "CI_GITEA_TOKEN не е зададен. Необходим за създаване на PR.",
     "de": "CI_GITEA_TOKEN nicht gesetzt. Erforderlich zum Erstellen eines PR.",